Re: [Buildroot] [PATCH v4 3/3] package/drogon: new package

From: Petr Vorel <petr.vorel@gmail.com>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: "Eric Le Bihan" <eric.le.bihan.dev@free.fr>,
	"Chen Pei" <cp0613@linux.alibaba.com>,
	"Gao Xiang" <hsiangkao@aol.com>,
	"Kurt Van Dijck" <dev.kurt@vandijck-laurijssen.be>,
	"Bernd Kuhls" <bernd@kuhls.net>,
	"Alistair Francis" <alistair@alistair23.me>,
	"José Luis Salvador Rufo" <salvador.joseluis@gmail.com>,
	"Grzegorz Blach" <grzegorz@blach.pl>,
	"Brandon Maier" <brandon.maier@collins.com>,
	"Philippe Proulx" <eeppeliteloop@gmail.com>,
	"Julien Olivain" <ju.o@free.fr>,
	"Marcin Niestroj" <m.niestroj@grinn-global.com>,
	"Rahul Bedarkar" <rahulbedarkar89@gmail.com>,
	buildroot@buildroot.org,
	"Sergio Prado" <sergio.prado@e-labworks.com>,
	"Giulio Benetti" <giulio.benetti@benettiengineering.com>,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
	"Fabrice Fontaine" <fontaine.fabrice@gmail.com>,
	"Etienne Carriere" <etienne.carriere@foss.st.com>
Subject: Re: [Buildroot] [PATCH v4 3/3] package/drogon: new package
Date: Tue, 21 Jul 2026 22:53:21 +0200	[thread overview]
Message-ID: <20260721205321.GC23326@pevik> (raw)
In-Reply-To: <20260721125337.2537436-3-dario.binacchi@amarulasolutions.com>

Hi Dario,

> Drogon is a C++17/20 based HTTP application framework. It can be used to
> easily build various types of web application server programs using C++.

> Project page: https://github.com/drogonframework/drogon

...
> diff --git a/package/drogon/0001-Fix-EPOLLRDHUP-POLLRDHUP-mismatch-on-Linux-SPARC-SPA.patch b/package/drogon/0001-Fix-EPOLLRDHUP-POLLRDHUP-mismatch-on-Linux-SPARC-SPA.patch
> new file mode 100644
> index 000000000000..7a9fab389fec
> --- /dev/null
> +++ b/package/drogon/0001-Fix-EPOLLRDHUP-POLLRDHUP-mismatch-on-Linux-SPARC-SPA.patch
> @@ -0,0 +1,93 @@
> +From 9ecfb965e6ea02583874e534f8936ebb43a9db29 Mon Sep 17 00:00:00 2001
> +From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> +Date: Mon, 20 Jul 2026 16:16:22 +0200
> +Subject: [PATCH] Fix EPOLLRDHUP/POLLRDHUP mismatch on Linux SPARC/SPARC64
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +Fix a build failure reported by Buildroot autobuild for the
> +bootlin-sparc64-glibc configuration:
> +
> +  EpollPoller.cc:41:26: error: static assertion failed:
> +  EPOLLRDHUP != POLLRDHUP
> +
> +On SPARC/SPARC64, EPOLLRDHUP (0x2000) and POLLRDHUP (0x0800) are
> +different bits, breaking the assumption elsewhere in this file that
> +epoll and poll flags are interchangeable.
> +
> +Introduce a combined RDHUP value for this architecture and translate
> +it before epoll_ctl() and after epoll_wait(), since revents_ is later
> +tested against POLLRDHUP in Channel::handleEvent() — otherwise
> +half-close detection would silently break at runtime.
> +
> +This patch is inspired by the equivalent fix in lighttpd:
> +https://redmine.lighttpd.net/issues/3251
> +
> +Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> +Upstream: https://github.com/an-tao/trantor/pull/407

I'm not sure what is the Buildroot's approach for git submodules.
As you use tallbar it should be ok like this (i.e. not adding trantor as a
separate package). Also other would probably raise a concern).

Otherwise LGTM.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot