Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Thomas Perale <thomas.perale@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/gdb: handle lzma option for host-gdb
Date: Fri,  4 Sep 2026 14:18:35 +0200	[thread overview]
Message-ID: <20260904121835.405609-1-thomas.perale@mind.be> (raw)
In-Reply-To: <20260824213315.3323882-1-thomas.petazzoni@bootlin.com>

In reply of:
> For target gdb, we properly enable/disable lzma support depending on
> BR2_PACKAGE_XZ.
> 
> However, for host-gdb we don't do anything, which can lead the gdb
> configure script to detect and use a system-provided xz library, which
> is not desired.
> 
> Instead, add an explicit option BR2_PACKAGE_HOST_GDB_LZMA, which when
> enabled pulls in host-xz, but also when disabled ensures gdb doesn't
> try to use a system-provided xz library.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to 2025.02.x & 2026.05.x. Thanks

> ---
>  package/gdb/Config.in.host | 5 +++++
>  package/gdb/gdb.mk         | 8 ++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/package/gdb/Config.in.host b/package/gdb/Config.in.host
> index 2e1eed6f50..823c2e9966 100644
> --- a/package/gdb/Config.in.host
> +++ b/package/gdb/Config.in.host
> @@ -44,6 +44,11 @@ config BR2_PACKAGE_HOST_GDB_SIM
>  	help
>  	  This option enables the simulator support in the cross gdb.
>  
> +config BR2_PACKAGE_HOST_GDB_LZMA
> +	bool "lzma support"
> +	help
> +	  This option enables lzma support in the cross gdb.
> +
>  choice
>  	prompt "GDB debugger Version"
>  	default BR2_GDB_VERSION_16
> diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
> index 685d1fe992..ebb80072cf 100644
> --- a/package/gdb/gdb.mk
> +++ b/package/gdb/gdb.mk
> @@ -293,6 +293,14 @@ else
>  HOST_GDB_CONF_OPTS += --disable-sim
>  endif
>  
> +ifeq ($(BR2_PACKAGE_HOST_GDB_LZMA),y)
> +HOST_GDB_CONF_OPTS += --with-lzma
> +HOST_GDB_CONF_OPTS += --with-liblzma-prefix=$(HOST_DIR)
> +HOST_GDB_DEPENDENCIES += host-xz
> +else
> +HOST_GDB_CONF_OPTS += --without-lzma
> +endif
> +
>  # Since gdb 9, in-tree builds for GDB are not allowed anymore,
>  # so we create a 'build' subdirectory in the gdb sources, and
>  # build from there.
> -- 
> 2.55.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2026-09-04 12:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 21:33 [Buildroot] [PATCH 1/2] package/gdb: handle lzma option for host-gdb Thomas Petazzoni via buildroot
2026-08-24 21:33 ` [Buildroot] [PATCH 2/2] package/gdb: handle xxhash optional dependency Thomas Petazzoni via buildroot
2026-08-25 11:49   ` Peter Korsgaard
2026-09-04 12:18   ` Thomas Perale via buildroot
2026-08-25 11:48 ` [Buildroot] [PATCH 1/2] package/gdb: handle lzma option for host-gdb Peter Korsgaard
2026-09-04 12:18 ` Thomas Perale via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260904121835.405609-1-thomas.perale@mind.be \
    --to=buildroot@buildroot.org \
    --cc=thomas.perale@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox