Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: buildroot@buildroot.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Andreas Ziegler <br025@umbiko.net>
Subject: [Buildroot] [PATCH] package/mpd: enable smb support on uClibc
Date: Sat, 12 Sep 2026 23:00:46 +0200	[thread overview]
Message-ID: <20260912210046.1550198-1-thomas.petazzoni@bootlin.com> (raw)

samba4 is available on !musl, but samba support in mpd is available
only with glibc. Turns out that samba support in mpd builds just fine
with uClibc-ng, and that samba4 no longer needs native RPC support: it
can use libtirpc when needed (it's handled in the samba4 package
itself).

Tested with the following defconfig:

BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_AARCH64_UCLIBC_BLEEDING_EDGE=y
BR2_PACKAGE_MPD=y
BR2_PACKAGE_MPD_LIBSMBCLIENT=y

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/mpd/Config.in | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/package/mpd/Config.in b/package/mpd/Config.in
index 1b6815e904..831cbe933d 100644
--- a/package/mpd/Config.in
+++ b/package/mpd/Config.in
@@ -226,16 +226,17 @@ config BR2_PACKAGE_MPD_LIBNFS
 comment "nfs support needs a toolchain w/ threads support"
 	depends on !(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC)
 
-comment "samba support needs a glibc toolchain w/ dynamic library, RPC"
-	depends on !BR2_TOOLCHAIN_USES_GLIBC || BR2_STATIC_LIBS || \
-		!BR2_TOOLCHAIN_HAS_NATIVE_RPC
+comment "samba support needs a glibc or uclibc toolchain w/ dynamic library, NPTL"
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
+	depends on BR2_TOOLCHAIN_USES_MUSL || BR2_STATIC_LIBS || \
+		!BR2_TOOLCHAIN_HAS_THREADS_NPTL
 
 config BR2_PACKAGE_MPD_LIBSMBCLIENT
 	bool "samba"
-	depends on BR2_TOOLCHAIN_USES_GLIBC
-	depends on !BR2_STATIC_LIBS
-	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC
-	depends on BR2_TOOLCHAIN_HAS_SYNC_4
+	depends on !BR2_TOOLCHAIN_USES_MUSL # samba4
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # samba4
+	depends on !BR2_STATIC_LIBS # samba4
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # samba4
 	select BR2_PACKAGE_SAMBA4
 	help
 	  Enable Samba support.
-- 
2.55.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

             reply	other threads:[~2026-09-12 21:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-12 21:00 Thomas Petazzoni via buildroot [this message]
2026-09-13  8:15 ` [Buildroot] [PATCH] package/mpd: enable smb support on uClibc Julien Olivain via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260912210046.1550198-1-thomas.petazzoni@bootlin.com \
    --to=buildroot@buildroot.org \
    --cc=br025@umbiko.net \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox