Re: [Buildroot] [PATCH] package/wpewebkit: propagate gst1-libav architecture dependency

From: Adrian Perez de Castro <aperez@igalia.com>
To: Michael Nosthoff <buildroot@heine.tech>
Cc: Michael Nosthoff via buildroot <buildroot@buildroot.org>,
	buildroot@buildroot.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Francois Perrad <francois.perrad@gadz.org>
Subject: Re: [Buildroot] [PATCH] package/wpewebkit: propagate gst1-libav architecture dependency
Date: Tue, 15 Sep 2026 10:01:26 +0200	[thread overview]
Message-ID: <20260915100126.GG925528998395952@igalia.com> (raw)
In-Reply-To: <20260915074215.620475-2-buildroot@heine.tech>

[-- Attachment #1.1: Type: text/plain, Size: 1936 bytes --]

Hello Michael,

On Tue, 15 Sep 2026 09:42:12 +0200 Michael Nosthoff via buildroot <buildroot@buildroot.org> wrote:
> BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA selects BR2_PACKAGE_GST1_LIBAV, which
> depends on BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS, but doesn't propagate
> this dependency. In practice, there is no issue, as webkitgtk is only
> available on a subset of CPU architectures, while
> BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS makes ffmpeg available on pretty much
> all CPU architectures, except Cortex-M, m68k coldfire, and some
> specific cases of OpenRISC, which are not supported by webkitgtk.
> 
> But for the sake of having correct dependency propagation, let's fix
> this.
> 
> The other packages selected by BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA have
> dependencies that are already handled at the top-level
> BR2_PACKAGE_WPEWEBKIT option.
> 
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> CC: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Acked-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
> 
> this is a 1:1 copy of da906556371ca3728b05ea4f33402891288cc027 which does
> the same for webkitgtk.
> 
> ---
>  package/wpewebkit/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
> index 03e9eaf59e..4a747a22c9 100644
> --- a/package/wpewebkit/Config.in
> +++ b/package/wpewebkit/Config.in
> @@ -87,6 +87,7 @@ comment "sandboxing supports needs a toolchain w/ headers >= 3.17"
>  
>  config BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
>  	bool "multimedia support"
> +	depends on BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS # gst1-libav
>  	select BR2_PACKAGE_GSTREAMER1
>  	select BR2_PACKAGE_GST1_PLUGINS_BAD
>  	select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DEBUGUTILS
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot