Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Thomas Perale <thomas.perale@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/ivi-homescreen: add missing BR2_USE_MMU dependencies
Date: Fri, 18 Sep 2026 15:08:57 +0200	[thread overview]
Message-ID: <20260918130857.162761-1-thomas.perale@mind.be> (raw)
In-Reply-To: <20260913162236.1673931-1-thomas.petazzoni@bootlin.com>

In reply of:
> - BR2_PACKAGE_IVI_HOMESCREEN_AUDIO_PLAYERS selects gstreamer1, which
>   has a depends on BR2_USE_MMU, but does not propagate it
> 
> - BR2_PACKAGE_IVI_HOMESCREEN_FLUTTER_SECURE_STORAGE_PLUGIN selects
>   libsecret, which has a depends on BR2_USE_MMU, but does not propagate
>   it
> 
> In practice there is no problem since ivi-homescreen depends on glibc,
> and glibc doesn't support any noMMU architecture. But just by walking
> the chain of option dependencies, this is not something that is
> theoretically guaranteed (making automated verification of
> dependencies difficult).
> 
> The other "depends on" from gstreamer1 and libsecret, BR2_USE_WCHAR
> and BR2_TOOLCHAIN_HAS_THREADS are on the other hand already handled by
> the top-level BR2_PACKAGE_IVI_HOMESCREEN option, so there is no
> ambiguity.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to 2025.02.x & 2026.08.x. Thanks

> ---
>  package/ivi-homescreen/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/ivi-homescreen/Config.in b/package/ivi-homescreen/Config.in
> index a4f5f6835f..d7cc4ce04e 100644
> --- a/package/ivi-homescreen/Config.in
> +++ b/package/ivi-homescreen/Config.in
> @@ -187,6 +187,7 @@ config BR2_PACKAGE_IVI_HOMESCREEN_TEXT_INPUT_PLUGIN
>  comment "plugins with external dependencies"
>  config BR2_PACKAGE_IVI_HOMESCREEN_AUDIO_PLAYERS
>  	bool "Audio Players"
> +	depends on BR2_USE_MMU # gstreamer1
>  	select BR2_PACKAGE_GSTREAMER1
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
> @@ -201,6 +202,7 @@ config BR2_PACKAGE_IVI_HOMESCREEN_AUDIO_PLAYERS
>  
>  config BR2_PACKAGE_IVI_HOMESCREEN_FLUTTER_SECURE_STORAGE_PLUGIN
>  	bool "Flutter Secure Storage"
> +	depends on BR2_USE_MMU # libsecret
>  	select BR2_PACKAGE_LIBSECRET
>  	help
>  	  Store data in secure storage
> -- 
> 2.55.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2026-09-18 13:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 16:22 [Buildroot] [PATCH] package/ivi-homescreen: add missing BR2_USE_MMU dependencies Thomas Petazzoni via buildroot
2026-09-13 19:35 ` Julien Olivain via buildroot
2026-09-18 13:08 ` Thomas Perale via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918130857.162761-1-thomas.perale@mind.be \
    --to=buildroot@buildroot.org \
    --cc=thomas.perale@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox