From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Thomas Perale <thomas.perale@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/pulseview: add missing 'select BR2_PACKAGE_QT5GUI'
Date: Fri, 18 Sep 2026 15:09:02 +0200 [thread overview]
Message-ID: <20260918130902.162948-1-thomas.perale@mind.be> (raw)
In-Reply-To: <20260913160834.1668831-1-thomas.petazzoni@bootlin.com>
In reply of:
> BR2_PACKAGE_PULSEVIEW selects BR2_PACKAGE_QT5BASE_PNG and
> BR2_PACKAGE_QT5BASE_WIDGETS, which both depend on
> BR2_PACKAGE_QT5BASE_GUI. It ends working because we also select
> BR2_PACKAGE_QT5SVG, which selects BR2_PACKAGE_QT5BASE_GUI, so there is
> no bug, but it's bit inconsistent to select sub-options that have a
> "depends on" without selecting the option they depend on.
>
> This not a bug fix, it has no functional implication.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Applied to 2025.02.x & 2026.08.x. Thanks
> ---
> package/pulseview/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/pulseview/Config.in b/package/pulseview/Config.in
> index b1f9dc25d7..b9dbd88c28 100644
> --- a/package/pulseview/Config.in
> +++ b/package/pulseview/Config.in
> @@ -17,6 +17,7 @@ config BR2_PACKAGE_PULSEVIEW
> select BR2_PACKAGE_LIBSIGROKCXX
> select BR2_PACKAGE_QT5
> select BR2_PACKAGE_QT5BASE
> + select BR2_PACKAGE_QT5BASE_GUI
> select BR2_PACKAGE_QT5BASE_PNG
> select BR2_PACKAGE_QT5BASE_WIDGETS
> select BR2_PACKAGE_QT5SVG
> --
> 2.55.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-09-18 13:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 16:08 [Buildroot] [PATCH] package/pulseview: add missing 'select BR2_PACKAGE_QT5GUI' Thomas Petazzoni via buildroot
2026-09-13 19:34 ` Julien Olivain via buildroot
2026-09-18 13:09 ` Thomas Perale via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918130902.162948-1-thomas.perale@mind.be \
--to=buildroot@buildroot.org \
--cc=thomas.perale@mind.be \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox