Re: [Buildroot] [PATCH v4 RESEND 2/3] package/python-snappy: bump version to 0.7.2

[Flaviu Nistor <flaviu.nistor@gmail.com>]

On Sun, Oct 11, 2026 at 1:12 PM, Peter Korsgaard wrote:
>> Even if there is a 0.7.3 on Pypi, there is no 0.7.3 release
>> on the project homepage, hence the bump to 0.7.2.
>
>How about contacting the author about the 0.7.3 tag?

I will try to contact. In previous situations when I send out a bump
it was indicated that I should use a Pypi release only if the tag is
released also on the repo. I think also in this case is better to have
the bump to 0.7.2 until 0.7.3 is released in the maintainer repo. 

>
>> Since 0.7.0 is switched from snappy library to cramjam so
>> update the PYTHON_SNAPPY_DEPENDENCIES.
>> Add also PYTHON_SNAPPY_SOURCE for correct package on Pypi.
>
>> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
>> ---
>> Changes in v4:
>> - Add also tests for python-snappy as indicated by Julien Olivain.
>> - More clean package Config.in
>> - Link to v3: https://lore.kernel.org/all/20260724065004.217411-1-flaviu.nistor@gmail.com/
>> Changes in v3:
>> - Add new package cramjam and to fix error indicated by Julien Olivain.
>> - Link to v2: https://lore.kernel.org/all/20260717061943.4491-1-flaviu.nistor@gmail.com/
>> Changes in v2:
>> - Fix error indicated by Julien Olivain when running make python-snappy-legal-info.
>> - Link to v1: https://lore.kernel.org/all/20260409152520.5894-1-flaviu.nistor@gmail.com/
>
>>  DEVELOPERS                               | 4 ++++
>>  package/python-snappy/Config.in          | 7 ++-----
>>  package/python-snappy/python-snappy.hash | 4 ++--
>>  package/python-snappy/python-snappy.mk   | 7 ++++---
>>  4 files changed, 12 insertions(+), 10 deletions(-)
>
>> diff --git a/DEVELOPERS b/DEVELOPERS
>> index 93519574c9..dbe05b7806 100644
>> --- a/DEVELOPERS
>> +++ b/DEVELOPERS
>> @@ -1135,7 +1135,11 @@ F:	support/testing/tests/package/test_python_networkmanager_goi.py
>>  F:	support/testing/tests/package/test_python_pyroute2.py
>
>>  N:	Flaviu Nistor <flaviu.nistor@gmail.com>
>> +F:	package/python-click/
>>  F:	package/python-cramjam/
>> +F:	package/python-rich/
>> +F:	package/python-smmap2/
>> +F:	package/python-snappy/
>
>It is good that you add yourself to DEVELOPERS, but the
>click/rich/smmap2 additions belong in a separate commit.
>

I just wanted to avoid some "noise" caused by separate patch, but yes,
you are right this would be the better approach. I will change this in v5.

>> -PYTHON_SNAPPY_VERSION = 0.6.1
>> -PYTHON_SNAPPY_SITE = https://files.pythonhosted.org/packages/98/7a/44a24bad98335b2c72e4cadcdecf79f50197d1bab9f22f863a274f104b96
>> +PYTHON_SNAPPY_VERSION = 0.7.2
>> +PYTHON_SNAPPY_SOURCE = python_snappy-$(PYTHON_SNAPPY_VERSION).tar.gz
>> +PYTHON_SNAPPY_SITE = https://files.pythonhosted.org/packages/cb/52/acd87583175fa930e4385f8a6164eb5909acd683c0e62ee01d41de8195a2
>>  PYTHON_SNAPPY_SETUP_TYPE = setuptools
>>  PYTHON_SNAPPY_LICENSE = BSD-3-Clause
>>  PYTHON_SNAPPY_LICENSE_FILES = LICENSE
>> -PYTHON_SNAPPY_DEPENDENCIES = snappy
>> +PYTHON_SNAPPY_DEPENDENCIES = host-python-cramjam python-cramjam
>
>Why do we need host-python-cramjam? Please describe that in the commit message.

This is a setup_requires in the setup.py (cramjam>=2.6.0). There is a build fail without it.
I will describe in the v5 commit message.
Thanks,
Flaviu

>
>-- 
>Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot