[Buildroot] [PATCH v4 00/15] check-package: warn about symbols not recognized by a package infra, support inline flags

[Angelo Compagnucci <angelo.compagnucci@gmail.com>]

This series resurrects two check-package series sent by Ricardo
Martincoski in 2023, which never got a review and have been sitting on
patchwork since then:

- "check-package: warn about symbols not recognized by a package
  infra" (January 2023): the fixes of the tree and patch 29 were
  applied, but the two new checks, patches 27 and 28, were not;
- "check-package: support inline flags" v3 (September 2023), which
  lets a file enable special rules of a check with a comment, and
  removes the list of Config.in files hard-coded in lib_config:Indent.

Both are rebased on current master and sent together, since they
touch the same code. This is v4 after the inline flags series; the two
checks were only sent once, as v1.

Patches 1 to 3 are the inline flags series, with only a conflict
solved in the first one.

Patches 14 and 15 are the two checks: TypoInVariableSuffix warns about
variables that the package infra used in the file does not know and
that nothing else uses, DisabledInstall about install hooks that never
run because the installation step is disabled. After almost four years, the
lists of variables known by each infra were outdated, and the checks
gave about 250 warnings on the current tree, so they are updated in
patch 14 with the variables added to the infras in the meantime.

The remaining warnings are all real problems: variables misspelled or
left behind by conversions to another infra. Rather than adding these
files to .checkpackageignore, patches 4 to 13 fix them, as the original
series did with its first 24 patches, so that the checks can go in with
no new entry in the ignore list but one:

- the license file of andes-spi-burn was never saved nor checked;
- the configure options of usbip were never passed;
- linux-pam has not been linked with libintl and libatomic since its
  move to meson, which breaks the build with an external libintl, as
  seen by the autobuilders (also in 2026.02.x);
- fbv, postgresql, libselinux, zfs, mesa3d, nxp-mwifiex and
  libglib2-bootstrap only had dead variables, removed with no change
  in the build.

The one entry left in .checkpackageignore is gcc-final: its m68k
ColdFire libgcc fixup hook is registered under a wrong name since
2023, so it never runs, but fixing it changes the ColdFire internal
toolchain and deserves its own patch and test.

This series supersedes the following patches, which can be marked as
superseded on patchwork:

- [27/29] utils/check-package: warn about symbols not recognized by a
  package infra (patch 14 of this series)
  https://patchwork.buildroot.org/project/buildroot/patch/20230101233653.487175-28-ricardo.martincoski@gmail.com/
- [28/29] utils/check-package: warn about disabled install (patch 15)
  https://patchwork.buildroot.org/project/buildroot/patch/20230101233653.487175-29-ricardo.martincoski@gmail.com/
- [next,v3,1/3] utils/check-package: factor-out check_disabled()
  (patch 1)
  https://patchwork.buildroot.org/project/buildroot/patch/20230903163509.614740-2-ricardo.martincoski@gmail.com/
- [next,v3,2/3] utils/check-package: support inline flags (patch 2)
  https://patchwork.buildroot.org/project/buildroot/patch/20230903163509.614740-3-ricardo.martincoski@gmail.com/
- [next,v3,3/3] utils/check-package: remove hard-coded list from
  lib_config:Indent (patch 3)
  https://patchwork.buildroot.org/project/buildroot/patch/20230903163509.614740-4-ricardo.martincoski@gmail.com/

Each patch has its own "Changes" notes.

Angelo Compagnucci (10):
  package/andes-spi-burn: fix the license files variable
  package/fbv: drop the unused configure options
  package/usbip: fix the configure options variable
  package/postgresql: drop the unused install-world options
  package/libselinux: drop the unused make environment
  package/zfs: drop the unused module subdirectories
  package/mesa3d: drop the unused host Vulkan drivers
  package/nxp-mwifiex: drop the unused make options
  package/libglib2/libglib2-bootstrap: drop unused variables
  package/linux-pam: fix linking with the NLS and atomic libraries

James Knight (1):
  utils/check-package: remove hard-coded list from lib_config:Indent

Ricardo Martincoski (4):
  utils/check-package: factor-out check_disabled()
  utils/check-package: support inline flags
  utils/check-package: warn about symbols not recognized by a package
    infra
  utils/check-package: warn about disabled install

 .checkpackageignore                           |   1 +
 fs/initramfs/initramfs.mk                     |   1 +
 linux/linux-ext-xenomai.mk                    |   2 +-
 package/Config.in                             |   2 +
 package/Config.in.host                        |   2 +
 package/andes-spi-burn/andes-spi-burn.hash    |   2 +-
 package/andes-spi-burn/andes-spi-burn.mk      |   2 +-
 package/fbv/fbv.mk                            |  13 +-
 package/kodi/Config.in                        |   2 +
 .../libglib2-bootstrap/libglib2-bootstrap.mk  |   3 -
 package/libselinux/libselinux.mk              |   3 -
 package/linux-pam/linux-pam.mk                |   2 +-
 package/luarocks/luarocks.mk                  |   2 +
 package/mesa3d/mesa3d.mk                      |   1 -
 package/nxp-mwifiex/nxp-mwifiex.mk            |   2 -
 package/postgresql/postgresql.mk              |   2 -
 package/usbip/usbip.mk                        |   2 +-
 package/x11r7/Config.in                       |   2 +
 package/zfs/zfs.mk                            |  12 -
 toolchain/toolchain.mk                        |   2 +
 utils/check-package                           |  21 +-
 utils/checkpackagelib/base.py                 |  21 +-
 utils/checkpackagelib/lib_config.py           |   8 +-
 utils/checkpackagelib/lib_mk.py               | 209 +++++++
 utils/checkpackagelib/pkg_infra.py            | 322 ++++++++++
 utils/checkpackagelib/test_base.py            | 131 +++++
 utils/checkpackagelib/test_lib_mk.py          | 555 ++++++++++++++++++
 utils/checkpackagelib/test_util.py            |   5 +-
 28 files changed, 1279 insertions(+), 53 deletions(-)
 create mode 100644 utils/checkpackagelib/pkg_infra.py
 create mode 100644 utils/checkpackagelib/test_base.py

-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot