Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: buildroot@buildroot.org
Cc: "Louis Aussedat" <aussedat.louis@gmail.com>,
	"James Hilliard" <james.hilliard1@gmail.com>,
	"Raphaël Mélotte" <raphael.melotte@mind.be>
Subject: [Buildroot] [PATCH 2025.02.x] package/python-dnspython: backport fix for GHSA-vvf4-9x63-8xvv
Date: Mon,  9 Nov 2026 16:55:08 +0100	[thread overview]
Message-ID: <20261109155508.583886-1-thomas.perale@mind.be> (raw)

Fixes the following vulnerability:

- GHSA-vvf4-9x63-8xvv

A maliciously crafted zone file could use a WKS record to consume
excessive memory and CPU, possibly causing the process to exit due to
memory exhaustion.

For more information, see:
 - https://github.com/rthalley/dnspython/security/advisories/GHSA-vvf4-9x63-8xvv
 - https://github.com/rthalley/dnspython/commit/388db14ee9923288f6e73f86e482c77706e59d73

Assisted-by: LLM
Signed-off-by: Thomas Perale <thomas.perale@mind.be>
---
 .../0002-Constrain-WKS-bitmap-size.patch      | 48 +++++++++++++++++++
 1 file changed, 48 insertions(+)
 create mode 100644 package/python-dnspython/0002-Constrain-WKS-bitmap-size.patch

diff --git a/package/python-dnspython/0002-Constrain-WKS-bitmap-size.patch b/package/python-dnspython/0002-Constrain-WKS-bitmap-size.patch
new file mode 100644
index 0000000000..369a99d85e
--- /dev/null
+++ b/package/python-dnspython/0002-Constrain-WKS-bitmap-size.patch
@@ -0,0 +1,48 @@
+From 388db14ee9923288f6e73f86e482c77706e59d73 Mon Sep 17 00:00:00 2001
+From: Bob Halley <halley@dnspython.org>
+Date: Tue, 3 Nov 2026 12:01:13 -0800
+Subject: [PATCH] Constrain WKS bitmap size.
+
+(cherry picked from commit a62e1be066da0ed71b5b59f37435bb17cfa0070f)
+
+CVE: GHSA-vvf4-9x63-8xvv
+Upstream: https://github.com/rthalley/dnspython/commit/388db14ee9923288f6e73f86e482c77706e59d73
+[thomas: backport
+  - stripped tests and changelog
+  - adjust context to 2.7.0, this version does not have the to_styled_text() method
+]
+Signed-off-by: Thomas Perale <thomas.perale@mind.be>
+---
+ dns/rdtypes/IN/WKS.py | 9 +++++++--
+ 1 file changed, 7 insertions(+), 2 deletions(-)
+
+diff --git a/dns/rdtypes/IN/WKS.py b/dns/rdtypes/IN/WKS.py
+index 881a7849..365dee61 100644
+--- a/dns/rdtypes/IN/WKS.py
++++ b/dns/rdtypes/IN/WKS.py
+@@ -44,6 +44,10 @@ class WKS(dns.rdata.Rdata):
+         self.address = self._as_ipv4_address(address)
+         self.protocol = self._as_uint8(protocol)
+         self.bitmap = self._as_bytes(bitmap)
++        if len(self.bitmap) > 8192:
++            raise ValueError(
++                "service bitmap must be between 0 and 8192 bytes inclusive"
++            )
+ 
+     def to_text(self, origin=None, relativize=True, **kw):
+         bits = []
+@@ -77,11 +81,12 @@ class WKS(dns.rdata.Rdata):
+                 else:
+                     protocol_text = "tcp"
+                 serv = socket.getservbyname(value, protocol_text)
++            if serv < 0 or serv > 65535:
++                raise ValueError("service must be between 0 and 65535 inclusive")
+             i = serv // 8
+             l = len(bitmap)
+             if l < i + 1:
+-                for _ in range(l, i + 1):
+-                    bitmap.append(0)
++                bitmap.extend(bytes(i + 1 - l))
+             bitmap[i] = bitmap[i] | (0x80 >> (serv % 8))
+         bitmap = dns.rdata._truncate_bitmap(bitmap)
+         return cls(rdclass, rdtype, address, protocol, bitmap)
-- 
2.56.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

                 reply	other threads:[~2026-11-09 15:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261109155508.583886-1-thomas.perale@mind.be \
    --to=buildroot@buildroot.org \
    --cc=aussedat.louis@gmail.com \
    --cc=james.hilliard1@gmail.com \
    --cc=raphael.melotte@mind.be \
    --cc=thomas.perale@mind.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox