Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tomas Mudrunka <tomas.mudrunka@gmail.com>
To: buildroot@buildroot.org
Cc: Adrian Perez de Castro <aperez@igalia.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Tomas Mudrunka <tomas.mudrunka@gmail.com>
Subject: [Buildroot] [PATCH v2 1/5] package/libmanette: select libgudev
Date: Fri, 13 Nov 2026 15:51:57 +0100	[thread overview]
Message-ID: <20261113145201.2357363-2-tomas.mudrunka@gmail.com> (raw)
In-Reply-To: <20261113145201.2357363-1-tomas.mudrunka@gmail.com>

libmanette selects hidapi, which selects libgudev, so libmanette has
always been built with gudev support (-Dgudev=enabled), which it uses
to discover game controllers through udev.

hidapi does not actually need libgudev, and the following patch drops
that dependency. Make libmanette select libgudev explicitly, and
enable gudev unconditionally, so that its behavior does not depend on
what hidapi selects.

All of libgudev's dependencies (BR2_PACKAGE_HAS_UDEV, BR2_USE_MMU,
BR2_USE_WCHAR, threads) are already libmanette dependencies.

Signed-off-by: Tomas Mudrunka <tomas.mudrunka@gmail.com>
---
 package/libmanette/Config.in     | 1 +
 package/libmanette/libmanette.mk | 9 ++-------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/package/libmanette/Config.in b/package/libmanette/Config.in
index d4f45e25ad..0f3a5a7bb0 100644
--- a/package/libmanette/Config.in
+++ b/package/libmanette/Config.in
@@ -9,6 +9,7 @@ config BR2_PACKAGE_LIBMANETTE
 	select BR2_PACKAGE_HIDAPI
 	select BR2_PACKAGE_LIBEVDEV
 	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBGUDEV
 	help
 	  GObject library which provides access to game controllers.
 
diff --git a/package/libmanette/libmanette.mk b/package/libmanette/libmanette.mk
index c320b84840..43b44efbe3 100644
--- a/package/libmanette/libmanette.mk
+++ b/package/libmanette/libmanette.mk
@@ -14,6 +14,7 @@ LIBMANETTE_INSTALL_STAGING = YES
 LIBMANETTE_DEPENDENCIES = \
 	libevdev \
 	libglib2 \
+	libgudev \
 	hidapi \
 	$(TARGET_NLS_DEPENDENCIES)
 
@@ -24,6 +25,7 @@ LIBMANETTE_CONF_OPTS = \
 	-Dbuild-tests=false \
 	-Dinstall-tests=false \
 	-Ddoc=false \
+	-Dgudev=enabled \
 	-Dvapi=false
 
 ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
@@ -33,11 +35,4 @@ else
 LIBMANETTE_CONF_OPTS += -Dintrospection=false
 endif
 
-ifeq ($(BR2_PACKAGE_LIBGUDEV),y)
-LIBMANETTE_CONF_OPTS += -Dgudev=enabled
-LIBMANETTE_DEPENDENCIES += libgudev
-else
-LIBMANETTE_CONF_OPTS += -Dgudev=disabled
-endif
-
 $(eval $(meson-package))
-- 
2.56.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-11-13 14:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 13:00 [Buildroot] [PATCH 1/1] package/hidapi: add support for build without hidraw support when udev is not available Tomas Mudrunka
2026-11-13 14:51 ` [Buildroot] [PATCH v2 0/5] package/hidapi: allow building without udev Tomas Mudrunka
2026-11-13 14:51   ` Tomas Mudrunka [this message]
2026-11-13 14:51   ` [Buildroot] [PATCH v2 2/5] package/hidapi: depend on udev instead of libgudev Tomas Mudrunka
2026-11-13 14:51   ` [Buildroot] [PATCH v2 3/5] package/hidapi: convert to cmake-package Tomas Mudrunka
2026-11-13 14:52   ` [Buildroot] [PATCH v2 4/5] package/hidapi: make the hidraw backend optional Tomas Mudrunka
2026-11-13 14:52   ` [Buildroot] [PATCH v2 5/5] DEVELOPERS: add Tomas Mudrunka for hidapi Tomas Mudrunka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113145201.2357363-2-tomas.mudrunka@gmail.com \
    --to=tomas.mudrunka@gmail.com \
    --cc=aperez@igalia.com \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox