Re: [Buildroot] [PATCH v2 2/2] configs/beaglev_ahead: new defconfig

["kilian.zinnecker--- via buildroot" <buildroot@buildroot.org>]

Hello Giulio, all,

> > This patch adds board support for the BeagleV-Ahead. It uses a
> > custom kernel for the board's SoC. As the SoC has an outdated and
> > currently not supported version of the RISC-V vector extension, the
> > vector extension is disabled.
> 
> can you please provide an URL to the product page?

Yes, I added an URL into the commit message of v3.

[--SNIP--]
> > --- /dev/null
> > +++ b/board/beaglev-ahead/post-image.sh
> > @@ -0,0 +1,6 @@
> > +#!/usr/bin/env bash
> > +set -e
> > +
> > +cp -r ${BUILD_DIR}/linux-custom/arch/riscv/boot/dts/thead/overlays/
> > ${BINARIES_DIR}
> linux-custom should substituted with $(LINUX_DIR)

I tried $(LINUX_DIR) and ${LINUX_DIR}, but both resulted in an empty string 
and as a consequence in a wrong path and broke the build. So in my v3 I kept 
it as it is for now. Should I try something else?

> > --- /dev/null
> > +++ b/configs/beaglev_ahead_defconfig
> > @@ -0,0 +1,44 @@
> > +BR2_riscv=y
> > +BR2_riscv_custom=y
> > +BR2_RISCV_ISA_CUSTOM_RVM=y
> > +BR2_RISCV_ISA_CUSTOM_RVA=y
> > +BR2_RISCV_ISA_CUSTOM_RVF=y
> > +BR2_RISCV_ISA_CUSTOM_RVD=y
> > +BR2_RISCV_ISA_CUSTOM_RVC=y
> 
> With commit cbd91e89e43d600172c62fd1cbd33aa74d0a851a all "_CUSTOM" have
> been dropped, so can you please replace all the:
> BR2_RISCV_ISA_CUSTOM_*
> occurences with:
> BR2_RISCV_ISA_*
> ?

I fixed it, thanks.

> > +BR2_GCC_VERSION_13_X=y
> 
> I think there is a reason you force using gcc 13, can you describe it in
> the commit log and here?

Yes, there were problems. I am not 100% sure, but as I remember it: the 
OpenSBI used has an old version and in its build, it does not define certain 
flags, which are needed by GCC 12 to activate the needed zifencei and zicsr 
extension. Those extension where redefined to be in some other extension pack 
of RiscV (or something like that, I don't remeber this exactly). Anyway it 
threw an error in GCC 12, and I thinkt to fix that, one would have to touch the 
old OpenSBI version. Switching to GCC 13 (where it works out of the box) seems 
then to be cleaner for me.

[--SNIP--]
> > +BR2_TARGET_UBOOT_CONFIG_FRAGMENT_FILES="board/beaglev-ahead/uboot.fragmen
> > t" +BR2_TARGET_UBOOT_FORMAT_BIN=y
> > +BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
> > +BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot-with-spl.bin"
> 
> Here you need to add:
> BR2_PACKAGE_HOST_DOSFSTOOLS=y
> otherwise it fails to build under buildroot/utils/docker-run

Added dosfstools to the defconfig, thanks!

> > +BR2_PACKAGE_HOST_MTOOLS=y
> > +BR2_PACKAGE_HOST_GENIMAGE=y
> > +BR2_PACKAGE_XUANTIE_BINS=y
> 
> After enabling BR2_RISCV_ISA_ options it builds successfully using
> buildroot/utils/docker-run

I build the image with buildroot/utils/docker-run and it boots. Thanks for the 
hint, I will use buildroot/utils/docker-run in the future as well!

Thanks for your review and best regards,
Kilian




_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot