Re: [Buildroot] [PATCH] package/kodi: fix definition of BR2_PACKAGE_KODI_ARCH_SUPPORTS

[Julien Olivain via buildroot <buildroot@buildroot.org>]

On 13/09/2026 14:16, Thomas Petazzoni via buildroot wrote:
> The definition of BR2_PACKAGE_KODI_ARCH_SUPPORTS is incorrect, it
> goes like this:
> 
>  	bool
> 	default y if BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS
> 	default y if BR2_PACKAGE_HOST_OPENJDK_BIN_ARCH_SUPPORTS
> 
> so it means it would be "y" if either
> BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS *OR*
> BR2_PACKAGE_HOST_OPENJDK_BIN_ARCH_SUPPORTS is true. While clearly what
> we need is for both to be true: ffmpeg should be available for the
> target architecture, and openjdk should be available for the host
> architecture.
> 
> One option was to change to:
> 
>  	bool
> 	default y if BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS && 
> BR2_PACKAGE_HOST_OPENJDK_BIN_ARCH_SUPPORTS
> 
> Or:
> 
>  	bool
> 	default y if BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS
> 	depends on BR2_PACKAGE_HOST_OPENJDK_BIN_ARCH_SUPPORTS
> 
> But we preferred:
> 
>  	bool
> 	default y
> 	depends on BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS
> 	depends on BR2_PACKAGE_HOST_OPENJDK_BIN_ARCH_SUPPORTS
> 
> Fixes: b6a2f494290d85a26798564992ddd1ac46c1a48d ("package/kodi: depend 
> on host-openjdk-bin instead of selecting BR2_NEEDS_HOST_JAVA")
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.

> Note: I have no strong opinion on the different options to express
> this "AND" dependency. So if people don't like the choice I've made in
> this commit, I'm happy to change to one of other options proposed in
> teh commit log.

I applied the patch because:
1. there is no policy defined,
2. it fixes a dependency issue, and
3. I'm fine with the way you wrote it.

If we decide a policy, we'll realign all _ARCH_SUPPORTS.

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot