Re: [Buildroot] [PATCH] andes_ae350_45: Fix build issues of AE350

[Kilian Zinnecker via buildroot <buildroot@buildroot.org>]

Hello Yu Chien Peter,

> - Select RVA extension so the toolchain uses glibc by default
> - Enable Zifencei and Zicsr for gcc-12 to fix U-Boot build failure

Yeah, this zifencei_zicsr extension flag thing is annoying ...

> Fixes:
> - https://gitlab.com/buildroot.org/buildroot/-/jobs/4839059655
> 
> Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
> ---
>  configs/andes_ae350_45_defconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/configs/andes_ae350_45_defconfig
> b/configs/andes_ae350_45_defconfig index 998276635b..faf29b8b6b 100644
> --- a/configs/andes_ae350_45_defconfig
> +++ b/configs/andes_ae350_45_defconfig
> @@ -1,6 +1,7 @@
>  BR2_riscv=y
>  BR2_riscv_custom=y
>  BR2_RISCV_ISA_CUSTOM_RVM=y
> +BR2_RISCV_ISA_CUSTOM_RVA=y
>  BR2_RISCV_ISA_CUSTOM_RVF=y
>  BR2_RISCV_ISA_CUSTOM_RVD=y
>  BR2_RISCV_ISA_CUSTOM_RVC=y
> @@ -38,7 +39,7 @@ BR2_TARGET_UBOOT_NEEDS_OPENSBI=y
>  BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
>  BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
>  BR2_TARGET_UBOOT_SPL=y
> -BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="ARCH_FLAGS=-march=rv64imafdc"
> +BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="ARCH_FLAGS=-march=rv64imafdc_zifencei_zic
> sr" BR2_PACKAGE_HOST_DOSFSTOOLS=y
>  BR2_PACKAGE_HOST_GENIMAGE=y
>  BR2_PACKAGE_HOST_MTOOLS=y

I am not sure, whether you need to specify custom makeopts for uboot after 
all: Looking at the current andes_ae350_45_defconfig (https://gitlab.com/
buildroot.org/buildroot/-/blob/4de60e41c3487946712da6d889ef89d325c2032a/
configs/andes_ae350_45_defconfig), it seems, that there is no special/custom gcc 
version defined. Hence the gcc version should be buildroot's current default 
version, i.e., v12.3.0. For this version, buildroot already adds the flags for 
zifencei and zicsr extension, see here:

https://gitlab.com/buildroot.org/buildroot/-/blob/
4de60e41c3487946712da6d889ef89d325c2032a/arch/arch.mk.riscv#L38-39

And I also believe, that these defines should be sufficient to set the rv64imafdc 
flags:

>  BR2_RISCV_ISA_CUSTOM_RVM=y
> +BR2_RISCV_ISA_CUSTOM_RVA=y
>  BR2_RISCV_ISA_CUSTOM_RVF=y
>  BR2_RISCV_ISA_CUSTOM_RVD=y
>  BR2_RISCV_ISA_CUSTOM_RVC=y

So I think setting BR2_RISCV_ISA_CUSTOM_RVA=y is correct. However, you could 
try whether it works, if you then completely remove the 
BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS?

Best regards,
Kilian



_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot