Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Raphael Pavlidis <raphael.pavlidis@gmail.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/8] package/shadow: install to staging for subids
Date: Tue, 25 Feb 2025 14:46:00 +0100	[thread overview]
Message-ID: <2363315a-c8cf-404f-ac02-59cba1dbbd7d@gmail.com> (raw)
In-Reply-To: <ac0db0d8eca730ce7d8b0763e750e72fe4e3aa1c.1740345268.git.yann.morin.1998@free.fr>

Hello Yann,
the changes looks good.

Regards,
Raphael Pavlidis

On 2/23/25 22:14, Yann E. MORIN wrote:
> When the subids feature is enabled, shadow will install a library and a
> header:
> 
>      $ sort output/build/shadow-4.16.0/.files-list.txt
>      [...]
>      shadow,./lib/libsubid.la
>      shadow,./lib/libsubid.so
>      shadow,./lib/libsubid.so.5
>      shadow,./lib/libsubid.so.5.0.0
>      [...]
>      shadow,./usr/include/shadow/subid.h
>      [...]
> 
> Install to staging in that case.
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Raphael Pavlidis <raphael.pavlidis@gmail.com>
> ---
>   package/shadow/shadow.mk | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/package/shadow/shadow.mk b/package/shadow/shadow.mk
> index f0a2b57b4d..2937a9601e 100644
> --- a/package/shadow/shadow.mk
> +++ b/package/shadow/shadow.mk
> @@ -46,6 +46,7 @@ SHADOW_CONF_OPTS += --disable-account-tools-setuid
>   endif
>   
>   ifeq ($(BR2_PACKAGE_SHADOW_SUBORDINATE_IDS),y)
> +SHADOW_INSTALL_STAGING = YES
>   SHADOW_CONF_OPTS += --enable-subordinate-ids
>   define SHADOW_SUBORDINATE_IDS_PERMISSIONS
>   	/usr/bin/newuidmap f 4755 0 0 - - - - -

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-02-25 13:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-23 21:14 [Buildroot] [PATCH 0/8] package/podman: new package (branch yem/podman) Yann E. MORIN
2025-02-23 21:14 ` [Buildroot] [PATCH 1/8] support/testing: set date in emulated machine Yann E. MORIN
2025-02-23 21:14 ` [Buildroot] [PATCH 2/8] package/shadow: install to staging for subids Yann E. MORIN
2025-02-25 13:46   ` Raphael Pavlidis [this message]
2025-02-23 21:14 ` [Buildroot] [PATCH 3/8] package/conmon: depends on systemd when enabled Yann E. MORIN
2025-02-23 21:14 ` [Buildroot] [PATCH 4/8] package/skopeo: add target variant Yann E. MORIN
2025-02-23 21:14 ` [Buildroot] [PATCH 5/8] package/cgroupfs-mount: tweak the kernel config Yann E. MORIN
2025-02-23 21:14 ` [Buildroot] [PATCH 6/8] package/cgroupfs-v2-mount: new package Yann E. MORIN
2025-02-23 21:14 ` [Buildroot] [PATCH 7/8] package/netavark: " Yann E. MORIN
2025-02-23 22:58   ` Julien Olivain
2025-02-23 21:14 ` [Buildroot] [PATCH 8/8] package/podman: " Yann E. MORIN
2025-02-23 23:02   ` Julien Olivain
2025-02-24 19:21     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2363315a-c8cf-404f-ac02-59cba1dbbd7d@gmail.com \
    --to=raphael.pavlidis@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox