Re: [Buildroot] [PATCH] package/mdadm: bump to version 4.6

From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Maxin John <maxin.john@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/mdadm: bump to version 4.6
Date: Fri, 24 Apr 2026 22:45:21 +0200	[thread overview]
Message-ID: <2388ac7c764d3229465afec26080faf9@free.fr> (raw)
In-Reply-To: <20260423205432.1832982-1-maxin.john@gmail.com>

Hi Maxin,

Thanks for the patch. I have few comments, see below.

On 23/04/2026 22:54, Maxin John wrote:
> Drop upstreamed/backported patches.
> 
> Release mail:
> https://lore.kernel.org/linux-raid/CALTww2_2pjjOSsVj-WT++m35555CjnPWokU7fut+HwUJVV-=ZQ@mail.gmail.com/

Since this patch updates from 4.3 to 4.6, could you also include the 
announces for 4.4 and 4.5, please?
For example:

4.6:
https://lore.kernel.org/linux-raid/CALTww2_2pjjOSsVj-WT++m35555CjnPWokU7fut+HwUJVV-=ZQ@mail.gmail.com/

4.5:
https://lore.kernel.org/linux-raid/CALTww293wnLE2+eZsZ42oyNZhS_cc2agB4GNqTz8j3xiP0ALWA@mail.gmail.com/

4.4:
https://lore.kernel.org/linux-raid/20241213121438.7ed6a0fd@mtkaczyk-private-dev/

> 
> Signed-off-by: Maxin John <maxin.john@gmail.com>
> ---
>  ...not-require-libudev-h-if-DNO_LIBUDEV.patch | 34 ---------------
>  ...ts-h-include-for-NAME_MAX-definition.patch | 32 --------------
>  .../0003-Create.c-fix-uclibc-build.patch      | 42 -------------------
>  .../0004-Makefile-Move-pie-to-LDFLAGS.patch   | 40 ------------------
>  package/mdadm/mdadm.hash                      |  5 ++-
>  package/mdadm/mdadm.mk                        |  6 +--
>  6 files changed, 6 insertions(+), 153 deletions(-)
>  delete mode 100644 
> package/mdadm/0001-udev-c-Do-not-require-libudev-h-if-DNO_LIBUDEV.patch
>  delete mode 100644 
> package/mdadm/0002-util-c-add-limits-h-include-for-NAME_MAX-definition.patch
>  delete mode 100644 package/mdadm/0003-Create.c-fix-uclibc-build.patch
>  delete mode 100644 
> package/mdadm/0004-Makefile-Move-pie-to-LDFLAGS.patch
[...]
> diff --git a/package/mdadm/mdadm.mk b/package/mdadm/mdadm.mk
> index 421f06d6953f..a6d7f98f0eb2 100644
> --- a/package/mdadm/mdadm.mk
> +++ b/package/mdadm/mdadm.mk
> @@ -4,9 +4,9 @@
>  #
>  
> ################################################################################
> 
> -MDADM_VERSION = 4.3
> -MDADM_SOURCE = mdadm-$(MDADM_VERSION).tar.xz
> -MDADM_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/raid/mdadm
> +MDADM_VERSION = 4.6
> +MDADM_SOURCE = mdadm-$(MDADM_VERSION).tar.gz

This MDADM_SOURCE line is no longer needed and can be removed. This is
because the .tar.gz name is the default value set by the package infra.

> +MDADM_SITE = 
> https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/snapshot

Also, since commit:
https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/commit/README.md?id=3f90be087fa62c0c7ed76c2ac26752f0ac3a89e7

The README.md mention:
"""
Effective immediately 
[Github](https://github.com/md-raid-utilities/mdadm) is the primary
location for **mdadm**. Use pull request to contribute.
"""

Could you add this information in the commit log and change and
change _SITE to use this primary github repo? For example, use:

MDADM_SITE = 
https://github.com/md-raid-utilities/mdadm/archive/refs/tags

>  MDADM_LICENSE = GPL-2.0+
>  MDADM_LICENSE_FILES = COPYING
>  MDADM_CPE_ID_VALID = YES
> --
> 2.47.3

Could you send an updated patch please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot