Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain <ju.o@free.fr>
To: Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/libcamera: Enable python bindings
Date: Wed, 23 Oct 2024 20:58:51 +0200	[thread overview]
Message-ID: <242a0544880ebfd54efeff702acca0ad@free.fr> (raw)
In-Reply-To: <20240620134959.1673948-1-kieran.bingham@ideasonboard.com>

Hi Kieran,

On 20/06/2024 15:49, Kieran Bingham wrote:
> Since libcamera commit f513fd70ba1a ("subprojects: Drop leftovers of
> pybind11"), merged before libcamera v0.1.0, libcamera has no longer
> relied on an external subproject branch of pybind to build the python
> bindings.
> 
> Provide a new package option to allow enabling the python bindings on
> libcamera when python3 is available in the buildroot configuration.
> Enabling the python bindings will select and bring in pybind as a
> dependency.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Thanks for the patch!  I applied it to master.

Best regards,

Julien.

> ---
>  package/libcamera/Config.in    | 7 +++++++
>  package/libcamera/libcamera.mk | 8 +++++++-
>  2 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> index e84b8d342eea..4699e382c760 100644
> --- a/package/libcamera/Config.in
> +++ b/package/libcamera/Config.in
> @@ -24,6 +24,13 @@ menuconfig BR2_PACKAGE_LIBCAMERA
> 
>  if BR2_PACKAGE_LIBCAMERA
> 
> +config BR2_PACKAGE_LIBCAMERA_PYTHON
> +	bool "python bindings"
> +	depends on BR2_PACKAGE_PYTHON3
> +	select BR2_PACKAGE_PYTHON_PYBIND
> +	help
> +	  Enable libcamera python bindings
> +
>  config BR2_PACKAGE_LIBCAMERA_V4L2
>  	bool "libcamera v4l2 compatibility layer"
>  	help
> diff --git a/package/libcamera/libcamera.mk 
> b/package/libcamera/libcamera.mk
> index dfcd340b75a0..100934a97d6f 100644
> --- a/package/libcamera/libcamera.mk
> +++ b/package/libcamera/libcamera.mk
> @@ -19,7 +19,6 @@ LIBCAMERA_CONF_OPTS = \
>  	-Dandroid=disabled \
>  	-Ddocumentation=disabled \
>  	-Dtest=false \
> -	-Dpycamera=disabled \
>  	-Dwerror=false
>  LIBCAMERA_INSTALL_STAGING = YES
>  LIBCAMERA_LICENSE = \
> @@ -45,6 +44,13 @@ ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_7),y)
>  LIBCAMERA_CXXFLAGS = -faligned-new
>  endif
> 
> +ifeq ($(BR2_PACKAGE_LIBCAMERA_PYTHON),y)
> +LIBCAMERA_DEPENDENCIES += python3 python-pybind
> +LIBCAMERA_CONF_OPTS += -Dpycamera=enabled
> +else
> +LIBCAMERA_CONF_OPTS += -Dpycamera=disabled
> +endif
> +
>  ifeq ($(BR2_PACKAGE_LIBCAMERA_V4L2),y)
>  LIBCAMERA_CONF_OPTS += -Dv4l2=true
>  else
> --
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2024-10-23 18:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 13:49 [Buildroot] [PATCH v2] package/libcamera: Enable python bindings Kieran Bingham
2024-07-22  9:45 ` Kieran Bingham
2024-07-23  7:06   ` Marcus Folkesson
2024-10-08 11:33     ` Kieran Bingham
2024-10-18  7:43       ` Kieran Bingham
2024-10-23 18:58 ` Julien Olivain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=242a0544880ebfd54efeff702acca0ad@free.fr \
    --to=ju.o@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=kieran.bingham@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox