Re: [Buildroot] [RFC PATCH v1 0/1] New "docker" ready qemu config

[Francis Laniel <flaniel@linux.microsoft.com>]

Hi.

Le mardi 19 avril 2022, 22:16:43 BST Arnout Vandecappelle a écrit :
> On 14/04/2022 19:28, Francis Laniel wrote:
> > Hi.
> > 
> > 
> > First, I hope you are fine and the same for your relatives.
> > 
> > In this contribution, I added a new qemu config for x86_64.
> > This configuration is mainly based on qemu_x86_64_defconfig but it adds
> > kernel CONFIG_ to be able to use docker.
> > It also adds package related to docker like DOCKER_CLI and CONTAINERD.
> 
>   We don't like adding "demo" defconfigs that are basically another
> defconfig with some packages enabled. It's true that there is some value to
> knowing which combination of packages can provide a certain super-feature,
> but the problem is that the basic config (in this case, qemu_x86_64) is not
> going to be useful for most people.
> 
>   In this particular case, there isn't even that much "combination". Just
> docker-engine and docker-cli.
> 
>   The kernel config options do have value, but these should instead be set
> by containerd (or docker-engine, or docker-proxy, as appropriate), using
> CONTAINERD_LINUX_CONFIG_FIXUPS.

Sorry, I did not check docker-engine.mk before writing this contribution.
I was not aware of PACKAGE_NAME_LINUX_CONFIG_FIXUPS and will rework my sysdig 
0.29.1 contribution to make use ot it!

> 
>   Regards,
>   Arnout
> 
> > The CONFIG_ options added were checked with moby check-config script [1].
> > 
> > I was able to build and execute the image with start-qemu.sh:
> > Welcome to Buildroot
> > buildroot login: root
> > # docker run --rm hello-world
> > Unable to find image 'hello-world:latest' locally
> > latest: Pulling from library/hello-world
> > 2db29710123e: Pull complete
> > Digest:
> > sha256:10d7d58d5ebd2a652f4d93fdd86da8f265f5318c6a73cc5b6a9798ff6d2b2e67
> > Status: Downloaded newer image for hello-world:latest
> > 
> > Hello from Docker!
> > This message shows that your installation appears to be working correctly.
> > 
> > Sadly, the image has to a bit big (more than 300M) but I think it is fine
> > since this image will only be used for virtualization.
> > 
> > If you say any way to improve this contribution, feel free to share it!
> > 
> > Francis Laniel (1):
> >    qemu_x86_64_docker: add new qemu defconfig
> >   
> >   DEVELOPERS                             |   2 +
> >   board/qemu/x86_64_docker/linux.config  | 112 +++++++++++++++++++++++++
> >   board/qemu/x86_64_docker/post-build.sh |  11 +++
> >   board/qemu/x86_64_docker/readme.txt    |   7 ++
> >   configs/qemu_x86_64_docker_defconfig   |  49 +++++++++++
> >   5 files changed, 181 insertions(+)
> >   create mode 100644 board/qemu/x86_64_docker/linux.config
> >   create mode 100755 board/qemu/x86_64_docker/post-build.sh
> >   create mode 100644 board/qemu/x86_64_docker/readme.txt
> >   create mode 100644 configs/qemu_x86_64_docker_defconfig
> > 
> > Best regards and thank you in advance.
> > ---
> > [1] https://github.com/moby/moby/blob/master/contrib/check-config.sh

Best regards.


_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot