From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE405C4167B for ; Tue, 5 Dec 2023 21:06:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 9580B61402; Tue, 5 Dec 2023 21:06:07 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 9580B61402 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MYIN_QMy9IzI; Tue, 5 Dec 2023 21:06:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 7B12D613FA; Tue, 5 Dec 2023 21:06:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 7B12D613FA Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 68B2C1BF35E for ; Tue, 5 Dec 2023 21:06:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 53A2541C21 for ; Tue, 5 Dec 2023 21:06:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 53A2541C21 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lz_z_ilmEj2b for ; Tue, 5 Dec 2023 21:05:59 +0000 (UTC) Received: from smtpcmd0987.aruba.it (smtpcmd0987.aruba.it [62.149.156.87]) by smtp4.osuosl.org (Postfix) with ESMTPS id DAE5041C5E for ; Tue, 5 Dec 2023 21:05:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org DAE5041C5E Received: from [192.168.50.162] ([84.33.84.190]) by Aruba Outgoing Smtp with ESMTPSA id Acc6rWf9KIk68Acc6rTQ8o; Tue, 05 Dec 2023 22:05:54 +0100 Message-ID: <27710fa6-7ff9-4775-8a20-4cb9ad7b5dc4@benettiengineering.com> Date: Tue, 5 Dec 2023 22:05:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Petr Vorel , buildroot@buildroot.org References: <20231205203938.131558-1-petr.vorel@gmail.com> Content-Language: en-US From: Giulio Benetti In-Reply-To: <20231205203938.131558-1-petr.vorel@gmail.com> X-CMAE-Envelope: MS4xfBfdFRaIbTRp8Zff7AW+SbpPFyjJBFdPW9815a/rYlIBa5VWoFZds2Shmozjpl8hxV0isD8ianiujt/rJtlgo6q7lA3JADk048x5j1Chix0BjoeXQsKE Xj7stEUddYIRvAjACnIyvRp7ATyKx1L6bTBQE58S0aTLfsSJmEQqxbcOOH2EpYiSS5t0Z4aiCNmCDEBgB1OFI0dOh1fVVNfAyu+Q0fT7+7yNOG2Tfk6Dd+jW vNMRRSRK54Ms18AZRtQzYfUOB6lekuV8ysIEPMLfxBptzXOQzsiDh6dg4xN0+dzJ X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1701810354; bh=jR4fGzoAiJq+R+NZVLrR5YQIqDh7Ey/bJY3NqqAHy6w=; h=Date:MIME-Version:Subject:To:From:Content-Type; b=GDnZ8hxAnGgBmaQZ53IzQNNkwoRFtN22rLsqSnlPeEFQiRt2bwyD4XJscsir3SeYQ 6kGiMwM/kiamjbEJOCYAjGIrtFn30h7egxcEUwxhr3ps6RU784D/2hE2aOFt7uRSxd rUto6kqavPhO+bqf0cunx/ThFL//DIyuIEC6J3RqB3K4T/3LWdfcPbpi3h4HWqZO4/ 9owUEq6doW4hWaSAhF87/UeHV7Uxz7RwPWaZAoIWXOwdrLXDpauT98r7Eed9hlJlWU b/iVmxSX3mIG/C5J/JtibMb/QV8drmMCACRXNoDKlXFkzxad3Cn3HoCgjPUfSaA9S/ tXU0Veq/Bgu6g== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.a=rsa-sha256 header.s=a1 header.b=GDnZ8hxA Subject: Re: [Buildroot] [PATCH] package/nfs-utils: bump version to 2.6.4 X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Yann E . MORIN" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Hi Petr, On 05/12/23 21:39, Petr Vorel wrote: > Remove patches backported from this release. > Backport patch from upstream ML needed for uClibc-ng. > > Require kernel 3.17 due getrandom() dependency. > > Signed-off-by: Petr Vorel > --- > Hi Giulio, Yann, > > I'm sorry, while I was able to reproduce the problem on nfs-utils master > Giulio reported [2], I'm not able to reproduce it on this patch due > failure on libressl (nfs-utils dependency): > > buildroot/c5fde6099a8b228a8bdc3154d1e47dfa192e94ed/output/build/libressl-3.8.2/crypto/bn/bn_add.c:65:21: fatal error: bn_arch.h: No such file or directory > #include "bn_arch.h" I can't honestly find out this build failure, can you point the autobuilder link? If sometimes you can't I've tried to apply and buildroot/utils/test-pkg -p nfs-utils but it fails due to missing uuid.h that has become mandatory during the building of host-nfs-utils. This is fixed by adding host-utils-linux to host-util-linux to HOST_NFS_UTILS_DEPENDENCIES. You can check host dependency issues while building using buildroot/utils/docker-run That way you have the minimum possible host libraries. Probably you have uuid lib installed in your system and you don't see the bug. Can you please add this fix to the patch? Thank you! Best regards -- Giulio Benetti CEO&CTO@Benetti Engineering sas > > Can we please merge this first? > > Kind regards, > Petr > > [1] http://autobuild.buildroot.net/results/c5fde6099a8b228a8bdc3154d1e47dfa192e94ed/ > [2] https://lore.kernel.org/buildroot/309e8ae9-47a4-4c49-9e69-09eec14b225a@benettiengineering.com/ > > I was not able to verify if thi > > ...event-and-libsqlite3-checked-when-nf.patch | 79 ------------------- > ...idd-reexport-.c-Add-missing-unistd.h.patch | 43 ++++++++++ > ...-guard-dlfcn.h-include-with-HAVE_DLF.patch | 44 ----------- > package/nfs-utils/Config.in | 1 + > package/nfs-utils/nfs-utils.hash | 4 +- > package/nfs-utils/nfs-utils.mk | 2 +- > 6 files changed, 47 insertions(+), 126 deletions(-) > delete mode 100644 package/nfs-utils/0001-configure.ac-libevent-and-libsqlite3-checked-when-nf.patch > create mode 100644 package/nfs-utils/0001-reexport-fsidd-reexport-.c-Add-missing-unistd.h.patch > delete mode 100644 package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch > > diff --git a/package/nfs-utils/0001-configure.ac-libevent-and-libsqlite3-checked-when-nf.patch b/package/nfs-utils/0001-configure.ac-libevent-and-libsqlite3-checked-when-nf.patch > deleted file mode 100644 > index a6a6d56d7f..0000000000 > --- a/package/nfs-utils/0001-configure.ac-libevent-and-libsqlite3-checked-when-nf.patch > +++ /dev/null > @@ -1,79 +0,0 @@ > -From bc4a5deef9f820c55fdac3c0070364c17cd91cca Mon Sep 17 00:00:00 2001 > -From: Wiktor Jaskulski > -Date: Thu, 11 May 2023 15:28:23 -0400 > -Subject: [PATCH] configure.ac: libevent and libsqlite3 checked when nfsv4 is > - disabled > - > -Upstream: https://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=bc4a5deef9f820c55fdac3c0070364c17cd91cca > - > -Signed-off-by: Steve Dickson > -Signed-off-by: Giulio Benetti > ---- > - configure.ac | 38 +++++++++++++++----------------------- > - 1 file changed, 15 insertions(+), 23 deletions(-) > - > -diff --git a/configure.ac b/configure.ac > -index 9df52e9c..6fbcb974 100644 > ---- a/configure.ac > -+++ b/configure.ac > -@@ -338,42 +338,34 @@ CPPFLAGS="${nfsutils_save_CPPFLAGS}" > - AC_CHECK_HEADER(uuid/uuid.h, , > - AC_MSG_ERROR([Cannot find needed header file uuid/uuid.h. Install libuuid-devel])) > - > -+dnl check for libevent libraries and headers > -+AC_LIBEVENT > -+ > -+dnl Check for sqlite3 > -+AC_SQLITE3_VERS > -+ > -+case $libsqlite3_cv_is_recent in > -+yes) ;; > -+unknown) > -+ dnl do not fail when cross-compiling > -+ AC_MSG_WARN([assuming sqlite is at least v3.3]) ;; > -+*) > -+ AC_MSG_ERROR([nfsdcld requires sqlite-devel]) ;; > -+esac > -+ > - if test "$enable_nfsv4" = yes; then > -- dnl check for libevent libraries and headers > -- AC_LIBEVENT > - > - dnl check for the keyutils libraries and headers > - AC_KEYUTILS > - > -- dnl Check for sqlite3 > -- AC_SQLITE3_VERS > -- > - if test "$enable_nfsdcld" = "yes"; then > - AC_CHECK_HEADERS([libgen.h sys/inotify.h], , > - AC_MSG_ERROR([Cannot find header needed for nfsdcld])) > -- > -- case $libsqlite3_cv_is_recent in > -- yes) ;; > -- unknown) > -- dnl do not fail when cross-compiling > -- AC_MSG_WARN([assuming sqlite is at least v3.3]) ;; > -- *) > -- AC_MSG_ERROR([nfsdcld requires sqlite-devel]) ;; > -- esac > - fi > - > - if test "$enable_nfsdcltrack" = "yes"; then > - AC_CHECK_HEADERS([libgen.h sys/inotify.h], , > - AC_MSG_ERROR([Cannot find header needed for nfsdcltrack])) > -- > -- case $libsqlite3_cv_is_recent in > -- yes) ;; > -- unknown) > -- dnl do not fail when cross-compiling > -- AC_MSG_WARN([assuming sqlite is at least v3.3]) ;; > -- *) > -- AC_MSG_ERROR([nfsdcltrack requires sqlite-devel]) ;; > -- esac > - fi > - > - else > --- > -2.34.1 > - > diff --git a/package/nfs-utils/0001-reexport-fsidd-reexport-.c-Add-missing-unistd.h.patch b/package/nfs-utils/0001-reexport-fsidd-reexport-.c-Add-missing-unistd.h.patch > new file mode 100644 > index 0000000000..3d00a93239 > --- /dev/null > +++ b/package/nfs-utils/0001-reexport-fsidd-reexport-.c-Add-missing-unistd.h.patch > @@ -0,0 +1,43 @@ > +From 8dbde05c4ed96bf043402f2f868ee2e62e1f89c6 Mon Sep 17 00:00:00 2001 > +From: Petr Vorel > +Date: Tue, 5 Dec 2023 20:40:36 +0100 > +Subject: [PATCH] reexport/{fsidd,reexport}.c: Add missing > +Upstream: https://lore.kernel.org/linux-nfs/20231205201556.5477-1-pvorel@suse.cz/ > + > +uClibc-ng requires this header for close(2), unlink(2) and write(2). > + > +Fixes: 1a4edb2a ("reexport/fsidd.c: Remove unused headers") > +Fixes: bdc79f02 ("support/reexport.c: Remove unused headers") > +Signed-off-by: Petr Vorel > +--- > + support/reexport/fsidd.c | 1 + > + support/reexport/reexport.c | 1 + > + 2 files changed, 2 insertions(+) > + > +diff --git a/support/reexport/fsidd.c b/support/reexport/fsidd.c > +index 8a70b78f..307e73e5 100644 > +--- a/support/reexport/fsidd.c > ++++ b/support/reexport/fsidd.c > +@@ -7,6 +7,7 @@ > + #include > + #endif > + #include > ++#include > + > + #include "conffile.h" > + #include "reexport_backend.h" > +diff --git a/support/reexport/reexport.c b/support/reexport/reexport.c > +index 0fb49a46..c7bff6a3 100644 > +--- a/support/reexport/reexport.c > ++++ b/support/reexport/reexport.c > +@@ -7,6 +7,7 @@ > + #endif > + #include > + #include > ++#include > + #include > + > + #include "nfsd_path.h" > +-- > +2.43.0 > + > diff --git a/package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch b/package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch > deleted file mode 100644 > index 6612847be7..0000000000 > --- a/package/nfs-utils/0002-support-reexport-guard-dlfcn.h-include-with-HAVE_DLF.patch > +++ /dev/null > @@ -1,44 +0,0 @@ > -From 274e4d212c30183242e48b639889865819f3ac33 Mon Sep 17 00:00:00 2001 > -From: Bernd Kuhls > -Date: Sun, 11 Jun 2023 08:57:11 +0200 > -Subject: [PATCH] support/reexport: guard dlfcn.h include with HAVE_DLFCN_H > - > -Upstream: http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=8125c6f4ad156a9bad0dc2cc42e0243380fc478d > - > -Signed-off-by: Bernd Kuhls > ---- > - support/reexport/fsidd.c | 2 ++ > - support/reexport/reexport.c | 2 ++ > - 2 files changed, 4 insertions(+) > - > -diff --git a/support/reexport/fsidd.c b/support/reexport/fsidd.c > -index 37649d06..d4b245e8 100644 > ---- a/support/reexport/fsidd.c > -+++ b/support/reexport/fsidd.c > -@@ -3,7 +3,9 @@ > - #endif > - > - #include > -+#ifdef HAVE_DLFCN_H > - #include > -+#endif > - #include > - #include > - #include > -diff --git a/support/reexport/reexport.c b/support/reexport/reexport.c > -index d597a2f7..d9a700af 100644 > ---- a/support/reexport/reexport.c > -+++ b/support/reexport/reexport.c > -@@ -2,7 +2,9 @@ > - #include > - #endif > - > -+#ifdef HAVE_DLFCN_H > - #include > -+#endif > - #include > - #include > - #include > --- > -2.39.2 > - > diff --git a/package/nfs-utils/Config.in b/package/nfs-utils/Config.in > index b4568dc6f3..dccb3acaf3 100644 > --- a/package/nfs-utils/Config.in > +++ b/package/nfs-utils/Config.in > @@ -6,6 +6,7 @@ config BR2_PACKAGE_NFS_UTILS > bool "nfs-utils" > depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc, rpcbind > depends on BR2_USE_MMU # fork() > + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 # getrandom() > select BR2_PACKAGE_LIBEVENT > select BR2_PACKAGE_LIBTIRPC # IPv6 requires libtirpc > select BR2_PACKAGE_SQLITE > diff --git a/package/nfs-utils/nfs-utils.hash b/package/nfs-utils/nfs-utils.hash > index 015906553d..9d74991df1 100644 > --- a/package/nfs-utils/nfs-utils.hash > +++ b/package/nfs-utils/nfs-utils.hash > @@ -1,4 +1,4 @@ > -# From https://www.kernel.org/pub/linux/utils/nfs-utils/2.6.3/sha256sums.asc > -sha256 38d89e853a71d3c560ff026af3d969d75e24f782ff68324e76261fe0344459e1 nfs-utils-2.6.3.tar.xz > +# From https://www.kernel.org/pub/linux/utils/nfs-utils/2.6.4/sha256sums.asc > +sha256 01b3b0fb9c7d0bbabf5114c736542030748c788ec2fd9734744201e9b0a1119d nfs-utils-2.6.4.tar.xz > # Locally computed > sha256 576540abf5e95029ad4ad90e32071385a5e95b2c30708c706116f3eb87b9a3de COPYING > diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk > index 3c85be0558..0ab852b045 100644 > --- a/package/nfs-utils/nfs-utils.mk > +++ b/package/nfs-utils/nfs-utils.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -NFS_UTILS_VERSION = 2.6.3 > +NFS_UTILS_VERSION = 2.6.4 > NFS_UTILS_SOURCE = nfs-utils-$(NFS_UTILS_VERSION).tar.xz > NFS_UTILS_SITE = https://www.kernel.org/pub/linux/utils/nfs-utils/$(NFS_UTILS_VERSION) > NFS_UTILS_LICENSE = GPL-2.0+ _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot