From: Pascal de Bruijn <p.debruijn@unilogic.nl>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/postgresql: fix filesystem naming consistency
Date: Thu, 28 Nov 2019 16:40:51 +0100 [thread overview]
Message-ID: <2997576693-13830@mail.unilogic.nl> (raw)
In-Reply-To: <20191128163653.42628ee8@windsurf>
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Pascal de Bruijn <p.debruijn@unilogic.nl>
Cc: <buildroot@busybox.net>
Sent: 11/28/2019 4:36 PM
Subject: Re: [Buildroot] [PATCH] package/postgresql: fix filesystem naming consistency
On Thu, 28 Nov 2019 12:15:42 +0100
Pascal de Bruijn <p.debruijn@unilogic.nl> wrote:
> Currently the service is called postgresql, but other filesystem
> references are called pgsql, which is inconsistent and confusing.
>
> Given that at least Debian uses postgresql in the filesystems
> as well I would suggest moving the filesystem reference to align
> with the service name as opposed to the other way around.
>
> Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>
> ---
> ?package/postgresql/Config.in ? ? ? ? ?| 2 +-
> ?package/postgresql/S50postgresql ? ? ?| 8 ++++----
> ?package/postgresql/postgresql.mk ? ? ?| 4 ++--
> ?package/postgresql/postgresql.service | 6 +++---
> ?4 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/package/postgresql/Config.in b/package/postgresql/Config.in
> index e548d3c..2f677da 100644
> --- a/package/postgresql/Config.in
> +++ b/package/postgresql/Config.in
> @@ -11,7 +11,7 @@ config BR2_PACKAGE_POSTGRESQL
> ? ? ? ? database system.
> ?
> ? ? ? ? Enable the readline package to gain readline support in
> - ? ? ? pgsql (the command line interpreter), which offers
> + ? ? ? psql (the command line interpreter), which offers
This doesn't seem to be related to the commit. Also, is the command
line tool really called psql ?
Yes, it's not directly related, but just a minor typo fix.
The command is indeed called psql.
Regards,
Pascal de Bruijn
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191128/ff218cd1/attachment.html>
next prev parent reply other threads:[~2019-11-28 15:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 11:15 [Buildroot] [PATCH] package/postgresql: fix filesystem naming consistency Pascal de Bruijn
2019-11-28 15:36 ` Thomas Petazzoni
2019-11-28 15:40 ` Pascal de Bruijn [this message]
2019-11-28 16:08 ` Peter Korsgaard
2019-11-28 21:38 ` Peter Seiderer
2019-11-29 8:32 ` Pascal de Bruijn
2019-12-01 14:07 ` Arnout Vandecappelle
2019-12-01 18:52 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2997576693-13830@mail.unilogic.nl \
--to=p.debruijn@unilogic.nl \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox