From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Condarelli Date: Sun, 22 May 2016 22:40:04 +0200 Subject: [Buildroot] [PATCH 1/1] Fix config.mak.uname to allow cross-compilation In-Reply-To: <20160522222942.37041c37@free-electrons.com> References: <1463948643-21344-1-git-send-email-mc5686@mclink.it> <1463948643-21344-2-git-send-email-mc5686@mclink.it> <20160522222942.37041c37@free-electrons.com> Message-ID: <2b22b774-92fe-c855-0c6e-af916a93dd30@mclink.it> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Thanks Thomas, comments below. Il 22/05/2016 22:29, Thomas Petazzoni ha scritto: > Hello, > > Thanks for your contribution. > > On Sun, 22 May 2016 22:24:03 +0200, Mauro Condarelli wrote: >> Current implementation imperatively sets variables from "uname" output. >> This breaks cross-compilation because uname is run on host while target >> configuration may be different. >> >> Make current behavior a non-imperative default, so it's possible to >> force different values setting make variables. >> >> To cross-compile it will be necessary to explicitly set the various >> uname_X variables to values compatible with target. >> No change is needed with normal host compilation. >> Patch is trivial. >> >> Signed-off-by: Mauro Condarelli >> --- >> config.mak.uname | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) > This patch cannot be applied, as it is a patch against Git directly, > while you should send patches against Buildroot. I.e, a patch that adds > a patch. I know. My patchset for BuildRoot is in "[Buildroot] [PATCH v2] Fix for GIT cross-compilation." and includes this patch. I sent this upstream and it's CC: here only FYI. Sorry if I broke any rules. Please advise. > > Best regards, > > Thomas Regards Mauro