Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@smile.fr>
To: Nicolas Tran <nicolas.tran@smile.fr>, buildroot@buildroot.org
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>
Subject: Re: [Buildroot] [PATCH 1/1] package/hyperfine: new package
Date: Mon, 23 May 2022 12:00:56 +0200	[thread overview]
Message-ID: <324b5350-5b37-2f4f-b206-12fe65bf7e58@smile.fr> (raw)
In-Reply-To: <20220519082800.926607-1-nicolas.tran@smile.fr>

Hello Nicolas,

Le 19/05/2022 à 10:28, Nicolas Tran a écrit :
> hyperfine is a benchmark tool written in Rust. It evaluates
> execution time of a command passed in arguments and make
> a relative comparison if multiple arguments are used at the
> same time.
> It can be convinient for purposes of Rust-written systems as

/convinient/convenient

> it runs in a stable version of Rust.

For now, Buildroot only support stable version of Rust.

> 
> The package has been checked with correct formatting and
> without typos:
> ./utils/check-package package/hyperfine/*
> 
> A CI test was run on gitlab.com to verify toolchain compatibilities.

If possible, provide the url of the gitlab-ci pipeline.

https://gitlab.com/kubu93/buildroot/-/pipelines/542342435

> 
> Signed-off-by: Nicolas Tran <nicolas.tran@smile.fr>
> ---
> test-pkg config:
> BR2_PACKAGE_HYPERFINE=y
> ---
>  package/Config.in                |  1 +
>  package/hyperfine/Config.in      | 11 +++++++++++
>  package/hyperfine/hyperfine.hash |  4 ++++
>  package/hyperfine/hyperfine.mk   | 12 ++++++++++++
>  4 files changed, 28 insertions(+)
>  create mode 100644 package/hyperfine/Config.in
>  create mode 100644 package/hyperfine/hyperfine.hash
>  create mode 100644 package/hyperfine/hyperfine.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 8892134133..4875f98a8d 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -104,6 +104,7 @@ menu "Debugging, profiling and benchmark"
>  	source "package/fwts/Config.in"
>  	source "package/gdb/Config.in"
>  	source "package/google-breakpad/Config.in"
> +	source "package/hyperfine/Config.in"
>  	source "package/iozone/Config.in"
>  	source "package/kexec/Config.in"
>  	source "package/kexec-lite/Config.in"
> diff --git a/package/hyperfine/Config.in b/package/hyperfine/Config.in
> new file mode 100644
> index 0000000000..4a67a071c3
> --- /dev/null
> +++ b/package/hyperfine/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_HYPERFINE
> +	bool "hyperfine"
> +	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
> +	select BR2_PACKAGE_HOST_RUSTC
> +	help
> +	  hyperfine is a benchmark tool written in Rust. It evaluates 
> +	  execution time of a command passed in arguments and make 
> +	  a relative comparison if multiple arguments are used at the 
> +	  same time.

This description is slightly better than "Command-line benchmarking tool" used
on github or other packaging.

> +
> +	  https://github.com/sharkdp/hyperfine
> diff --git a/package/hyperfine/hyperfine.hash b/package/hyperfine/hyperfine.hash
> new file mode 100644
> index 0000000000..50cc7694b3
> --- /dev/null
> +++ b/package/hyperfine/hyperfine.hash
> @@ -0,0 +1,4 @@
> +# Locally computed
> +sha256  28fcd72c556b4ca2150577217a4d7d51907b7e00ff86b764943d068202a92ace  hyperfine-1.14.0.tar.gz
> +sha256  c71d239df91726fc519c6eb72d318ec65820627232b2f796219e87dcf35d0ab4  LICENSE-APACHE
> +sha256  1dfee18c2ff07ce551de4d6a1d2db158c0380746b488a7f0d08c8e0d3568b7c3  LICENSE-MIT
> diff --git a/package/hyperfine/hyperfine.mk b/package/hyperfine/hyperfine.mk
> new file mode 100644
> index 0000000000..62246f002e
> --- /dev/null
> +++ b/package/hyperfine/hyperfine.mk
> @@ -0,0 +1,12 @@
> +################################################################################
> +#
> +# hyperfine
> +#
> +################################################################################
> +
> +HYPERFINE_VERSION = 1.14.0
> +HYPERFINE_SITE = $(call github,sharkdp,hyperfine,v$(HYPERFINE_VERSION))
> +HYPERFINE_LICENSE = Apache-2.0 or MIT
> +HYPERFINE_LICENSE_FILES = LICENSE-APACHE LICENSE-MIT

Reviewed-by: Romain Naour <romain.naour@smile.fr>

Best regards,
Romain


> +
> +$(eval $(cargo-package))

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-05-23 10:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19  8:28 [Buildroot] [PATCH 1/1] package/hyperfine: new package Nicolas Tran
2022-05-23 10:00 ` Romain Naour [this message]
2022-07-25  6:36 ` Thomas Petazzoni via buildroot
2022-07-25  9:25   ` Nicolas TRAN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=324b5350-5b37-2f4f-b206-12fe65bf7e58@smile.fr \
    --to=romain.naour@smile.fr \
    --cc=buildroot@buildroot.org \
    --cc=eric.le.bihan.dev@free.fr \
    --cc=nicolas.tran@smile.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox