Re: [Buildroot] [PATCH 1/1] boot/opensbi: introduce BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS

["Noah Hütter" <noahhuetter@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 3022 bytes --]



On 5/12/22 23:57, Arnout Vandecappelle wrote:
> 
> 
> On 12/05/2022 08:50, Noah Hütter wrote:
>> Hi Alistair,
>>
>> Is there any action needed from my side to get this committed?
> 
>   It's just one of the +-200 pending patches that are not trivial.

Thanks for the update, I didn't want to put pressure on anyone, I'm a 
first time contributor and want to make no mistakes :).

>>
>> Noah
>>
>> On 4/28/22 00:55, Alistair Francis wrote:
>>> On Wed, Apr 27, 2022 at 11:14 PM Noah Huetter <noahhuetter@gmail.com> 
>>> wrote:
>>>>
>>>> Signed-off-by: Noah Huetter <noahhuetter@gmail.com>
>>>
>>> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
>>>
>>> Alistair
>>>
>>>> ---
>>>>   boot/opensbi/Config.in  | 6 ++++++
>>>>   boot/opensbi/opensbi.mk | 3 ++-
>>>>   2 files changed, 8 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/boot/opensbi/Config.in b/boot/opensbi/Config.in
>>>> index f1443498d9..ff095ea800 100644
>>>> --- a/boot/opensbi/Config.in
>>>> +++ b/boot/opensbi/Config.in
>>>> @@ -119,4 +119,10 @@ config BR2_TARGET_OPENSBI_FW_FDT_PATH
>>>>            must be set in the U-Boot configuration for this file to be
>>>>            produced.
>>>>
>>>> +config BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS
>>>> +       string "Custom make options"
>>>> +       help
>>>> +         List of custom make options passed at build time. Can be
>>>> +         used for example to pass a BUILD_INFO= value.
> 
>   In this case, it's not trivial because the use case is not clear. 
> Almost every package has some random make, cmake, meson or whatever 
> options that you could pass to it. What makes OpenSBI so special that 
> you need to pass a freeform list of additional options?

In my specific case as described in the help, the value to `BUILD_INFO`. 
 From looking at other packages I deduced that the _CUSTOM_MAKEOPTS is a 
common config to packages and added it to OpenSBI. Did I overlook something?

Best,
Noah

>>>> +
>>>>   endif
>>>> diff --git a/boot/opensbi/opensbi.mk b/boot/opensbi/opensbi.mk
>>>> index 8e055633a8..d007ae1299 100644
>>>> --- a/boot/opensbi/opensbi.mk
>>>> +++ b/boot/opensbi/opensbi.mk
>>>> @@ -31,7 +31,8 @@ BR_NO_CHECK_HASH_FOR += $(OPENSBI_SOURCE)
>>>>   endif
>>>>
>>>>   OPENSBI_MAKE_ENV = \
>>>> -       CROSS_COMPILE=$(TARGET_CROSS)
>>>> +       CROSS_COMPILE=$(TARGET_CROSS) \
>>>> +       $(call qstrip,$(BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS))
>>>>
>>>>   OPENSBI_PLAT = $(call qstrip,$(BR2_TARGET_OPENSBI_PLAT))
>>>>   ifneq ($(OPENSBI_PLAT),)
>>>> -- 
>>>> 2.35.1
>>>>
>>>> _______________________________________________
>>>> buildroot mailing list
>>>> buildroot@buildroot.org
>>>> https://lists.buildroot.org/mailman/listinfo/buildroot
>>
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot