Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [for-next: 1/2] package/make: add host variant
Date: Sun, 2 Sep 2018 14:25:49 +0200	[thread overview]
Message-ID: <3523002c-076c-e61c-31d2-6dd5bb291728@gmail.com> (raw)
In-Reply-To: <20180902093918.3cd04d18@windsurf>

Hi Thomas,

Le 02/09/2018 ? 09:39, Thomas Petazzoni a ?crit?:
> Hello,
> 
> On Sat, 1 Sep 2018 21:20:36 +0200, Romain Naour wrote:
> 
>> From [1]:
>> AC_CHECK_PROG_VER(MAKE, gnumake gmake make, --version,
>>   [GNU Make[^0-9]*\([0-9][0-9.]*\)],
>>   [3.79* | 3.[89]* | [4-9].* | [1-9][0-9]*], critic_missing="$critic_missing make")
>>
>> On your host (Fedora) you have a symlink to make named gmake (gmake -> make)
>>
>> You can verify that glibc is using gmake instead of make by looking at config.log.
>>
>> configure:4672: checking for gnumake
>> configure:4702: result: no
>> configure:4672: checking for gmake
>> configure:4688: found /usr/bin/gmake
>> configure:4699: result: gmake
>> configure:4714: checking version of gmake
>> configure:4724: result: 4.2.1, ok
> 
> OK.
> 
>> We can verify that glibc build-system is really using gmake:
>> ac_cv_prog_MAKE=gmake
>>
>> So if we want glibc build system to use the make binary provided by Buildroot we
>> must create gnumake and gmake symlink in $(HOST_DIR)/bin when installing host-make.
> 
> Or we can pass ac_cv_prog_MAKE=make. But OK, perhaps doing the symlinks
> is better.

Indeed (I tried with this solution) but I believe that creating gnumake and
gmake symlinks in HOST_DIR is more bulletproof. I don't know if another package
is trying to use gnumake or gmake.

> 
> Thanks for the explanation!

You're welcome!

Best regards,
Romain

> 
> Thomas
> 

      reply	other threads:[~2018-09-02 12:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-30 20:30 [Buildroot] [for-next: 1/2] package/make: add host variant Romain Naour
2018-08-30 20:30 ` [Buildroot] [for-next: 2/2] dependencies: host-make version check Romain Naour
2018-09-02 20:51   ` Thomas Petazzoni
2018-09-01 12:51 ` [Buildroot] [for-next: 1/2] package/make: add host variant Thomas Petazzoni
2018-09-01 19:20   ` Romain Naour
2018-09-02  7:39     ` Thomas Petazzoni
2018-09-02 12:25       ` Romain Naour [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3523002c-076c-e61c-31d2-6dd5bb291728@gmail.com \
    --to=romain.naour@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox