From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] dhcpcd: correct ccache-fixing patch for Xtensa
Date: Sun, 29 Jun 2014 15:45:39 +0200 [thread overview]
Message-ID: <36a9b65b2892d7db4206.1404049539@localhost> (raw)
The Xtensa gcc does not seem to like output on /dev/null. The applied patch
on dhcpcd is thus unusable, and a more verbose version involving a temporary
file is needed.
Reported-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
package/dhcpcd/dhcpcd-0001-fix-build-with-ccache.patch | 28 +++++++++---
1 files changed, 20 insertions(+), 8 deletions(-)
diff -r 4d6d2ac6a601 -r 36a9b65b2892 package/dhcpcd/dhcpcd-0001-fix-build-with-ccache.patch
--- a/package/dhcpcd/dhcpcd-0001-fix-build-with-ccache.patch Thu Jun 19 18:13:36 2014 +0200
+++ b/package/dhcpcd/dhcpcd-0001-fix-build-with-ccache.patch Sun Jun 29 15:42:36 2014 +0200
@@ -9,23 +9,35 @@
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
-Upstream status: another implementation was submitted, modified by
-maintainer Roy, then simplified based on my suggestion. This patch is a fold
-of the two upstream patches:
+Upstream status: backport of
http://roy.marples.name/projects/dhcpcd/info/5f4bf91142fceac502c478886aeb5079a184bb43
-http://roy.marples.name/projects/dhcpcd/info/26bc10be2405659bdf31d690a72d377d6b67ebd4
+
+Note: a simplification of this patch was accepted upstream, but turns out to be
+non-usable by the Xtensa architecture. This was also reported upstream and
+should normally be reverted soon.
diff -r 66c8bdc88858 configure
--- a/configure Sat Jun 21 16:54:30 2014 +0200
-+++ b/configure Sun Jun 22 15:20:25 2014 +0200
-@@ -272,8 +272,9 @@
++++ b/configure Sun Jun 29 15:42:08 2014 +0200
+@@ -272,8 +272,20 @@
fi
echo "Using compiler .. $CC"
-if ! type "$CC" >/dev/null 2>&1; then
- echo "$CC is not an executable"
-+if ! echo "int main(void) { return 0; }" | $CC -x c -o /dev/null - 2>/dev/null
-+then
++cat <<EOF >_test.c
++int main(void) {
++ return 0;
++}
++EOF
++_CC=true
++if $CC _test.c -o _test >/dev/null 2>&1; then
++ [ -x _test ] || _CC=false
++else
++ _CC=false
++fi
++rm -f _test.c _test
++if ! $_CC; then
+ echo "$CC does not create executables"
exit 1
fi
next reply other threads:[~2014-06-29 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 13:45 Thomas De Schampheleire [this message]
2014-06-29 14:16 ` [Buildroot] [PATCH] dhcpcd: correct ccache-fixing patch for Xtensa Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36a9b65b2892d7db4206.1404049539@localhost \
--to=patrickdepinguin@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox