From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3 of 6 v4] pkg-virtual: simplify definition of FOO_VERSION to 'virtual'
Date: Wed, 11 Jun 2014 21:12:26 +0200 [thread overview]
Message-ID: <39d24c5ad999ce15ca58.1402513946@localhost> (raw)
In-Reply-To: <patchbomb.1402513943@localhost>
As mentioned in the e-mail accompanying the introduction of the pkg-virtual
infrastructure [1], the definition of FOO_VERSION is 'strange'.
After the cleanup of single/double dollar signs in inner-generic-package,
the special construction in pkg-virtual is no longer needed and can be
simplified.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
[1] http://lists.busybox.net/pipermail/buildroot/2014-April/093670.html
---
v4: no changes
v3: no changes
v2: no changes
Note: this patch should only be applied when the first patch in this series
is.
package/pkg-virtual.mk | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff -r 686857abb0b9 -r 39d24c5ad999 package/pkg-virtual.mk
--- a/package/pkg-virtual.mk Sat May 10 10:04:45 2014 +0200
+++ b/package/pkg-virtual.mk Sun May 11 10:32:44 2014 +0200
@@ -45,8 +45,7 @@
$(2)_SOURCE =
# Fake a version string, so it looks nicer in the build log
-$(3)_VERSION = virtual
-HOST_$(3)_VERSION = virtual
+$(2)_VERSION = virtual
# This must be repeated from inner-generic-package, otherwise we get an empty
# _DEPENDENCIES
next prev parent reply other threads:[~2014-06-11 19:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 19:12 [Buildroot] [PATCH 0 of 6 v4] infra: fix dollar signs; remove some undefined versions Thomas De Schampheleire
2014-06-11 19:12 ` [Buildroot] [PATCH 1 of 6 v4] infra: consistently use double dollar signs inside inner-xxx-targets Thomas De Schampheleire
2014-06-11 19:12 ` [Buildroot] [PATCH 2 of 6 v4] infra: add comment describing single/double dollar-sign rules Thomas De Schampheleire
2014-06-11 19:12 ` Thomas De Schampheleire [this message]
2014-06-11 19:12 ` [Buildroot] [PATCH 4 of 6 v4] toolchain/toolchain-buildroot: migrate to virtual package infrastructure Thomas De Schampheleire
2014-06-11 19:12 ` [Buildroot] [PATCH 5 of 6 v4] makedevs: change version from 'undefined' to 'buildroot-$(BR2_VERSION)' Thomas De Schampheleire
2014-06-11 19:12 ` [Buildroot] [PATCH 6 of 6 v4] mkpasswd: " Thomas De Schampheleire
2014-06-14 17:15 ` [Buildroot] [PATCH 0 of 6 v4] infra: fix dollar signs; remove some undefined versions Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39d24c5ad999ce15ca58.1402513946@localhost \
--to=patrickdepinguin@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox