Re: [Buildroot] [PATCH 1/1] boot/syslinux: fix build with GCC 14.x

[Lance Fredrickson <lancethepants@gmail.com>]

I'm not sure I understand. The patch which you included in your reply 
does have a "Signed-off-by" line present.  Also, the last release of 
syslinux was in 2014, and buildroot seems to be carrying many patches 
against that release, so I was under the impression upstream is probably 
not accepting patches at this point.

The "From" when sending this patch doesn't match my name in the 
"Signed-off-by" as another maintainer mentioned in another patch I sent 
in, but this one was also sent before I received that reply.

Lance

On 6/19/2024 2:25 PM, Arnout Vandecappelle wrote:
>  Hi Lance,
>
> On 05/06/2024 23:20, lancethepants wrote:
>> Add missing stdio.h include. Without it results in the following 
>> error under GCC 14.x
>>
>> ../../../com32/lib/syslinux/debug.c: In function ‘syslinux_debug’:
>> ../../../com32/lib/syslinux/debug.c:91:5: error: implicit declaration 
>> of function ‘printf’ [-Wimplicit-function-declaration]
>>     91 |     printf("Dynamic debug unavailable\n");
>>
>> Signed-off-by: Lance Fredrickson <lancethepants@gmail.com>
>> ---
>>   .../0020-pull-in-stdio-h-for-gcc14.patch      | 25 +++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>   create mode 100644 boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch
>>
>> diff --git a/boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch 
>> b/boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch
>> new file mode 100644
>> index 0000000000..6711c7aa78
>> --- /dev/null
>> +++ b/boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch
>> @@ -0,0 +1,25 @@
>> +From dfa2705100a893bc017d23406daa9a383fbc3c95 Mon Sep 17 00:00:00 2001
>> +From: lancethepants <lancethepants@gmail.com>
>> +Date: Wed, 5 Jun 2024 14:31:38 -0600
>> +Subject: [PATCH] com32/lib/syslinux/debug.c: add missing stdio.h 
>> include.
>> +
>> +Fixes building with GCC 14.x
>
>  As check-package reports, the patch is missing a Signed-off-by (to 
> indicate that you are allowed to contribute it under the syslinux 
> license) and an Upstream: indicator. We expect you to submit the patch 
> upstream before you submit it to buildroot.
>
>  Regards,
>  Arnout
>
>> +---
>> + com32/lib/syslinux/debug.c | 1 +
>> + 1 file changed, 1 insertion(+)
>> +
>> +diff --git a/com32/lib/syslinux/debug.c b/com32/lib/syslinux/debug.c
>> +index d9ab863f..e8f53d57 100644
>> +--- a/com32/lib/syslinux/debug.c
>> ++++ b/com32/lib/syslinux/debug.c
>> +@@ -1,6 +1,7 @@
>> + #include <linux/list.h>
>> + #include <string.h>
>> + #include <stdbool.h>
>> ++#include <stdio.h>
>> +
>> + #ifdef DYNAMIC_DEBUG
>> +
>> +--
>> +2.39.2
>> +

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot