Re: [Buildroot] [Help] How to bump a package, e.g., OpenSBI?

[Julien Olivain <ju.o@free.fr>]

Hi Kilian,

On 26/12/2024 22:19, Kilian Zinnecker via buildroot wrote:
> Hello all,
> 
> I saw that RISC-V's OpenSBI recently got an update to v1.6.[1] In 
> buildroot
> the package's latest version is v1.5.[2] I would like to bump it. Ofc. 
> I'd
> have to adjust the version in the Config.in, and also the hashes in the 
> hash
> file.

This is correct. You can have a look how the previous versions
were updated, for details. For example, see [3].
This will update only the default "latest" OpenSBI version. Usually,
defconfigs in Buildroot are using a specific, fixed custom version.

> I am wondering what is required with regards to testing? Currently I
> cannot test whether RISC-V boards would work with OpenSBI v1.6. 
> However, I
> could do a build-test, i.e., pick a RISC-V defconfig, adjust its 
> OpenSBI
> version to 1.6 (just locally, not sending any patch with that regard to 
> any
> board's defconfig) and see, whether OpenSBI v1.6 gets build 
> successfully. Is
> this sufficient as testing before sending a patch bumping OpenSBI? Or 
> is
> additional testing expected before sending a bump-patch?

There is no strict rules for testing. The general guideline would be
"the more, the better" ;)  Doing a compilation test only for such a
component is a bit limited. Doing a runtime test would be better.
So, if you have a specific board in mind, you can ask in the patch
cover letter (on in the patch note) for somebody with access to the
board to test and reply with the "Tested-by:" tag.

Fortunately, in Buildroot, there is several defconfigs for
RISC-V emulators [4] [5] [6] [7]. If you don't have a specific board
in mind, you could use those to runtime test this new v1.6. Those
emulators are usually good references.

For example, after locally modifying those defconfigs to use this new
OpenSBI version, you can use commands such as:

     make qemu_riscv64_virt_defconfig
     make
     output/images/start-qemu.sh

Or:

     make spike_riscv64_defconfig
     make
     board/spike/riscv64/start.sh

and check you can reach the user-space and the system login. You can
describe your test methodology in the cover letter (or patch note) to 
make
reviews faster for the maintainers. See for example [8].

> Best regards,
> Kilian
> 
> [1] https://github.com/riscv-software-src/opensbi/commit/
> bd613dd92113f683052acfb23d9dc8ba60029e0a
> [2] 
> https://gitlab.com/buildroot.org/buildroot/-/blob/master/boot/opensbi/
> Config.in?ref_type=heads#L21-22

Best regards,

Julien.

[3] 
https://gitlab.com/buildroot.org/buildroot/-/commit/c583befc8e92d0ae70d4fcb967bf8257ea94d577
[4] 
https://gitlab.com/buildroot.org/buildroot/-/blob/master/configs/qemu_riscv32_virt_defconfig
[5] 
https://gitlab.com/buildroot.org/buildroot/-/blob/master/configs/qemu_riscv64_virt_defconfig
[6] 
https://gitlab.com/buildroot.org/buildroot/-/blob/master/configs/spike_riscv32_defconfig
[7] 
https://gitlab.com/buildroot.org/buildroot/-/blob/master/configs/spike_riscv64_defconfig
[8] 
https://patchwork.ozlabs.org/project/buildroot/patch/20240622114621.447904-1-ju.o@free.fr/
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot