From: Bernd Kuhls <bernd.kuhls@t-online.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/icu: Fix nios2 build
Date: Sat, 03 Aug 2019 09:12:35 +0200 [thread overview]
Message-ID: <3oof1gxvf.ln2@ID-313208.user.individual.net> (raw)
In-Reply-To: 20190803084652.1a4a4acf@windsurf.home
Hi Thomas,
Am Sat, 03 Aug 2019 08:46:52 +0200 schrieb Thomas Petazzoni:
> What is ICU-20751 ? It's not clear if the patch comes from upstream or
> not, since you are the author of patch.
ICU-20751 is the name of my bug report:
https://unicode-org.atlassian.net/browse/ICU-20751
The project mandats that patch subjects start with the name of the ticket:
http://site.icu-project.org/repository/gitdev
"Always prefix your commit statements with the Jira ticket number using
this pattern (including the space after the number; note: no colon):
ICU-23456 what I changed"
> Indeed, I see the nios2 and xtensa fixes are not the same, so I guess
> they have a different double conversion behavior, but how did you figure
> this out ?
Yes, the fix is the same, I split it into two pull requests, but they
patch the same part of the long ifdef statement and the project allows:
"You can have multiple pull requests per ticket."
> If it's an upstream fix, could you share a link to it ?
No, the patches are authored by me and sent upstream as pull requests.
Ah, and here is the point: I forgot to add the pull request URL to the
patches, sorry, sent v2.
Regards, Bernd
next prev parent reply other threads:[~2019-08-03 7:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-03 6:31 [Buildroot] [PATCH 1/2] package/icu: Fix nios2 build Bernd Kuhls
2019-08-03 6:31 ` [Buildroot] [PATCH 2/2] package/icu: Fix xtensa build Bernd Kuhls
2019-08-03 6:46 ` [Buildroot] [PATCH 1/2] package/icu: Fix nios2 build Thomas Petazzoni
2019-08-03 7:12 ` Bernd Kuhls [this message]
2019-08-03 8:16 ` Thomas Petazzoni
2019-08-03 13:53 ` Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3oof1gxvf.ln2@ID-313208.user.individual.net \
--to=bernd.kuhls@t-online.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox