public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Marcus Hoffmann via buildroot <buildroot@buildroot.org>
To: yegorslists@googlemail.com, buildroot@buildroot.org
Cc: ju.o@free.fr
Subject: Re: [Buildroot] [PATCH] package/libftdi1: enable static only build
Date: Fri, 10 Apr 2026 18:36:36 +0200	[thread overview]
Message-ID: <41420683-9e63-45f5-beaa-155ee152f01e@bubu1.eu> (raw)
In-Reply-To: <20260410090649.3029441-1-yegorslists@googlemail.com>

Hi Yegor,

On 4/10/26 11:06, yegorslists--- via buildroot wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> libfdti1 provides configuration options SHAREDLIBS and STATICLIBS
> that allow any combination of static/shared libraries.
> 
> Fixes:
> https://autobuild.buildroot.org/results/d7b9a45ccffc1c9e3fd796c3e46ee396b7d88272/
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---

Finally applied with a small change, see below.

>   package/libftdi1/libftdi1.mk | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/package/libftdi1/libftdi1.mk b/package/libftdi1/libftdi1.mk
> index 31ffa1aca3..0595ccf963 100644
> --- a/package/libftdi1/libftdi1.mk
> +++ b/package/libftdi1/libftdi1.mk
> @@ -13,6 +13,14 @@ LIBFTDI1_LICENSE_FILES = LICENSE COPYING.LIB
>   LIBFTDI1_CONFIG_SCRIPTS = libftdi1-config
>   LIBFTDI1_CONF_OPTS = -DDOCUMENTATION=OFF -DEXAMPLES=OFF
>   
> +ifeq ($(BR2_STATIC_LIBS),y)
> +LIBFTDI1_CONF_OPTS += -DSTATICLIBS=ON -DSHAREDLIBS=OFF
> +else ifeq ($(BR2_SHARED_LIBS),y)
> +LIBFTDI1_CONF_OPTS += -DSTATICLIBS=OFF -DSHAREDLIBS=ON
> +else

I changed this to an explicit

else ifeq ($(BR2_SHARED_STATIC_LIBS),y)

This pattern is also used elsewhere in the codebase already.

> +LIBFTDI1_CONF_OPTS += -DSTATICLIBS=ON -DSHAREDLIBS=ON
> +endif
> +
>   ifeq ($(BR2_PACKAGE_LIBFTDI1_LIBFTDIPP1),y)
>   LIBFTDI1_LICENSE += , GPL-2.0 with exception (libftdipp1)
>   LIBFTDI1_LICENSE_FILES += COPYING.GPL

Best,
Marcus
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-04-10 16:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10  9:06 [Buildroot] [PATCH] package/libftdi1: enable static only build yegorslists--- via buildroot
2026-04-10 16:36 ` Marcus Hoffmann via buildroot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-08-29 11:04 yegorslists--- via buildroot
2026-02-12 10:35 ` Yegor Yefremov via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41420683-9e63-45f5-beaa-155ee152f01e@bubu1.eu \
    --to=buildroot@buildroot.org \
    --cc=buildroot@bubu1.eu \
    --cc=ju.o@free.fr \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox