Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Santos <casantos@datacom.com.br>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] coreutils: optimize the '[' symlink
Date: Wed, 11 Jul 2018 19:06:13 -0300 (BRT)	[thread overview]
Message-ID: <420364696.3228173.1531346773590.JavaMail.zimbra@datacom.com.br> (raw)
In-Reply-To: <7ebb787a-3798-5534-9cef-2012943d50ad@mind.be>

> From: "Arnout Vandecappelle" <arnout@mind.be>
> To: "Baruch Siach" <baruch@tkos.co.il>, "buildroot" <buildroot@busybox.net>
> Cc: "DATACOM" <casantos@datacom.com.br>
> Sent: Wednesday, July 11, 2018 6:49:43 PM
> Subject: Re: [PATCH v2 2/2] coreutils: optimize the '[' symlink

> On 11-07-18 21:51, Baruch Siach wrote:
>> Link '[' directly to the coreutils binary instead of going through
>> 'test'.
> 
> One more small question: did you do a runtime test to be sure that this
> actually works? (That said, if this doesn't work, then the previous one also
> can't have worked.)

Yes, but it must be invoked directly since '[' is a shell built-in
command:

   # type [
   [ is a shell builtin
   # /usr/bin/[ -d / ] && echo ok
   ok

-- 
Carlos Santos (Casantos) - DATACOM, P&D
?Marched towards the enemy, spear upright, armed with the certainty
that only the ignorant can have.? ? Epitaph of a volunteer

  reply	other threads:[~2018-07-11 22:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-11 19:51 [Buildroot] [PATCH v2 1/2] coreutils: fix chroot installation Baruch Siach
2018-07-11 19:51 ` [Buildroot] [PATCH v2 2/2] coreutils: optimize the '[' symlink Baruch Siach
2018-07-11 21:48   ` Carlos Santos
2018-07-11 21:49   ` Arnout Vandecappelle
2018-07-11 22:06     ` Carlos Santos [this message]
2018-07-12 19:02     ` Baruch Siach
2018-07-16 14:41 ` [Buildroot] [PATCH v2 1/2] coreutils: fix chroot installation Thomas Petazzoni
2018-07-19 21:38 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=420364696.3228173.1531346773590.JavaMail.zimbra@datacom.com.br \
    --to=casantos@datacom.com.br \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox