From: Romain Naour <romain.naour@smile.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 3/3] package/python-stegano : new package
Date: Thu, 6 Jan 2022 20:22:35 +0100 [thread overview]
Message-ID: <424a55f7-27ea-e369-a753-1453214ef408@smile.fr> (raw)
In-Reply-To: <20200905232559.53e7b9a9@windsurf.home>
Hello Jugurtha, Thomas,
Le 05/09/2020 à 23:25, Thomas Petazzoni a écrit :
> Hello Jugurtha,
>
> On Tue, 1 Sep 2020 16:37:31 +0200
> Jugurtha BELKALEM <jugurtha.belkalem@smile.fr> wrote:
>
>> Steganography is the art and science of writing hidden
>> messages in such a way that no one , apart from the sender
>> and intended recipient , suspects the existence of the message,
>> a form of security through obscurity.
>> Steganography is often used with cryptography.
>>
>> More about python-stegano is available at :
>> https://pypi.org/project/stegano/.
>>
>> Stegano can be tested :
>> $ python3
>>>>> from stegano import lsb
>>>>> secret = lsb.hide("./image.png", "Hello World")
>>>>> secret.save("./image-with-steganography.png")
>> To get back text :
>>>>> clear_message = lsb.reveal("./image-with-steganography")
>
> Not a strict requirement, but since you have a simple test case, what
> about adding a runtime test in support/testing/ ?
>
>> diff --git a/package/python-stegano/Config.in b/package/python-stegano/Config.in
>> new file mode 100644
>> index 0000000000..b0b209c5f8
>> --- /dev/null
>> +++ b/package/python-stegano/Config.in
>> @@ -0,0 +1,14 @@
>> +config BR2_PACKAGE_PYTHON_STEGANO
>> + bool "python-stegano"
>> + depends on BR2_PACKAGE_PYTHON3
>> + select BR2_PACKAGE_JPEG #runtime
>> + select BR2_PACKAGE_LIBXML2 #runtime
>> + select BR2_PACKAGE_OPENJPEG #runtime
>
> Could you give more details about the dependency on those 3 libraries?
> Is it because python-pillow must be built with openjpeg support and
> jpeg support? Or is it just because in your situation, you were using
> jpg pictures?
>
> What about the libxml2 dependency?
No reply since September 2020, I have marked this patch as "Changes Requested".
Best regards,
Romain
>
> Best regards,
>
> Thomas
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-01-06 19:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 14:37 [Buildroot] [PATCH 0/3] package/python-stegano Jugurtha BELKALEM
2020-09-01 14:37 ` [Buildroot] [PATCH 1/3] package/python-crayons : new package Jugurtha BELKALEM
2020-09-05 21:20 ` Thomas Petazzoni
2020-09-01 14:37 ` [Buildroot] [PATCH 2/3] package/python-piexif " Jugurtha BELKALEM
2020-09-05 21:22 ` Thomas Petazzoni
2020-09-01 14:37 ` [Buildroot] [PATCH 3/3] package/python-stegano " Jugurtha BELKALEM
2020-09-05 21:25 ` Thomas Petazzoni
2022-01-06 19:22 ` Romain Naour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=424a55f7-27ea-e369-a753-1453214ef408@smile.fr \
--to=romain.naour@smile.fr \
--cc=buildroot@buildroot.org \
--cc=jugurtha.belkalem@smile.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox