Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3] configs/cubieboard1: new defconfig
Date: Thu, 30 May 2024 22:55:36 +0200	[thread overview]
Message-ID: <427d70f0-cfe7-4fed-9d4f-be63ecc39ff8@benettiengineering.com> (raw)
In-Reply-To: <ZljXofs1V1Vtb7Nh@Apollo>

Hi Gero,

On 30/05/24 21:46, Gero Schwäricke wrote:
> This patch adds a new defconfig for Cubieboard1 made by Cubietech. It is
> based on the Allwinner A10 SoC. See:
> http://www.cubietech.com/product-detail/cubieboard1.
> 
> The defconfig uses upstream U-Boot and Linux.
> 
> Signed-off-by: Gero Schwäricke <gero.schwaericke@posteo.de>
> ---
> Changes v2 -> v3:
>    - bump u-boot and kernel version
>    - update kernel dts path (new vendor subdir)
>    - update my email address in DEVELOPERS
>    - add BR2_DOWNLOAD_FORCE_CHECK_HASHES=y to defconfig
>    - add BR2_GLOBAL_PATCH_DIR and custom hashes (utils/add-custom-hashes)
>    - minor improvements to readme.txt
>    - add link to board details in commit message (requested by Giulio)
> Changes v1 -> v2:
>    - fix commit title
>    - add entry to DEVELOPERS
>    - add board/cubieboard1/readme.txt
>    - use extlinux.conf instead of boot.cmd
> ---
>   DEVELOPERS                                    |  4 ++
>   board/cubietech/cubieboard1/genimage.cfg      | 16 ++++++++
>   .../patches/linux-headers/linux-headers.hash  |  2 +
>   .../cubieboard1/patches/linux/linux.hash      |  2 +
>   .../cubieboard1/patches/uboot/uboot.hash      |  2 +
>   board/cubietech/cubieboard1/readme.txt        | 32 ++++++++++++++++
>   .../boot/extlinux/extlinux.conf               |  5 +++
>   configs/cubieboard1_defconfig                 | 38 +++++++++++++++++++
>   8 files changed, 101 insertions(+)
>   create mode 100644 board/cubietech/cubieboard1/genimage.cfg
>   create mode 100644 board/cubietech/cubieboard1/patches/linux-headers/linux-headers.hash
>   create mode 100644 board/cubietech/cubieboard1/patches/linux/linux.hash
>   create mode 100644 board/cubietech/cubieboard1/patches/uboot/uboot.hash
>   create mode 100644 board/cubietech/cubieboard1/readme.txt
>   create mode 100644 board/cubietech/cubieboard1/rootfs_overlay/boot/extlinux/extlinux.conf
>   create mode 100644 configs/cubieboard1_defconfig
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 53ec6049a1..3157e2557e 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1202,6 +1202,10 @@ F:	package/flannel/
>   N:	Geoffrey Ragot <geoffreyragot@gmail.com>
>   F:	package/python-pyyaml/
>   
> +N:	Gero Schwaericke <gero.schwaericke@posteo.de>
> +F:	board/cubietech/cubieboard1/
> +F:	configs/cubieboard1_defconfig
> +
>   N:	Gilles Talis <gilles.talis@gmail.com>
>   F:	board/freescale/imx8mmevk/
>   F:	board/friendlyarm/nanopi-r2s/
> diff --git a/board/cubietech/cubieboard1/genimage.cfg b/board/cubietech/cubieboard1/genimage.cfg
> new file mode 100644
> index 0000000000..92c8677545
> --- /dev/null
> +++ b/board/cubietech/cubieboard1/genimage.cfg
> @@ -0,0 +1,16 @@
> +image sdcard.img {
> +	hdimage {
> +	}
> +
> +	partition u-boot {
> +		in-partition-table = "no"
> +		image = "u-boot-sunxi-with-spl.bin"
> +		offset = 8K
> +		size = 1016K # 1MB - 8KB
> +	}
> +
> +	partition rootfs {
> +		partition-type = 0x83
> +		image = "rootfs.ext4"
> +	}
> +}
> diff --git a/board/cubietech/cubieboard1/patches/linux-headers/linux-headers.hash b/board/cubietech/cubieboard1/patches/linux-headers/linux-headers.hash
> new file mode 100644
> index 0000000000..04e69e882a
> --- /dev/null
> +++ b/board/cubietech/cubieboard1/patches/linux-headers/linux-headers.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256  b78dcd09f6b725872a2c0c87a70a064b0fbbcccfe5ce60aa46c669934a9e28b6  linux-6.8.11.tar.xz
> diff --git a/board/cubietech/cubieboard1/patches/linux/linux.hash b/board/cubietech/cubieboard1/patches/linux/linux.hash
> new file mode 100644
> index 0000000000..04e69e882a
> --- /dev/null
> +++ b/board/cubietech/cubieboard1/patches/linux/linux.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256  b78dcd09f6b725872a2c0c87a70a064b0fbbcccfe5ce60aa46c669934a9e28b6  linux-6.8.11.tar.xz
> diff --git a/board/cubietech/cubieboard1/patches/uboot/uboot.hash b/board/cubietech/cubieboard1/patches/uboot/uboot.hash
> new file mode 100644
> index 0000000000..97a2b4eaf9
> --- /dev/null
> +++ b/board/cubietech/cubieboard1/patches/uboot/uboot.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256  18a853fe39fad7ad03a90cc2d4275aeaed6da69735defac3492b80508843dd4a  u-boot-2024.04.tar.bz2
> diff --git a/board/cubietech/cubieboard1/readme.txt b/board/cubietech/cubieboard1/readme.txt
> new file mode 100644
> index 0000000000..d5033f473f
> --- /dev/null
> +++ b/board/cubietech/cubieboard1/readme.txt
> @@ -0,0 +1,32 @@
> +Cubietech Cubieboard1
> +=====================
> +
> +Cubieboard1 is the first generation Cubieboard from Cubietech.
> +
> +Cubietech:
> +http://www.cubietech.com/product-detail/cubieboard1
> +
> +Linux Sunxi Wiki:
> +https://linux-sunxi.org/Cubietech_Cubieboard
> +
> +Building
> +--------
> +
> +Configure and build with
> +
> +  make cubieboard1_defconfig
> +  make
> +
> +Flashing
> +--------
> +
> +Flash the sdcard image onto a micro sdcard with
> +
> +  dd if=output/images/sdcard.img of=/dev/sdX bs=1M conv=fsync
> +
> +Running
> +-------
> +
> +Connect a 3V3 serial interface to the serial header on the top side of the board
> +(between the USB jacks and the A10 chip). Then provide power to the board. The
> +interface uses 115200 baud.
> diff --git a/board/cubietech/cubieboard1/rootfs_overlay/boot/extlinux/extlinux.conf b/board/cubietech/cubieboard1/rootfs_overlay/boot/extlinux/extlinux.conf
> new file mode 100644
> index 0000000000..2fde683f38
> --- /dev/null
> +++ b/board/cubietech/cubieboard1/rootfs_overlay/boot/extlinux/extlinux.conf
> @@ -0,0 +1,5 @@
> +DEFAULT linux
> +LABEL linux
> +  KERNEL /boot/zImage
> +  DEVICETREE /boot/sun4i-a10-cubieboard.dtb
> +  APPEND console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p1 rootwait
> diff --git a/configs/cubieboard1_defconfig b/configs/cubieboard1_defconfig
> new file mode 100644
> index 0000000000..85d528e41f
> --- /dev/null
> +++ b/configs/cubieboard1_defconfig
> @@ -0,0 +1,38 @@
> +# Architecture
> +BR2_arm=y
> +BR2_cortex_a8=y
> +
> +# Toolchain options
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_8=y
> +
> +# Bootloader
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2024.04"
> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="Cubieboard"
> +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
> +BR2_TARGET_UBOOT_SPL=y
> +BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
> +
> +# Kernel
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.8.11"
> +BR2_LINUX_KERNEL_DEFCONFIG="sunxi"
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="allwinner/sun4i-a10-cubieboard"
> +BR2_LINUX_KERNEL_INSTALL_TARGET=y
> +
> +# Filesystem
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_ROOTFS_OVERLAY="board/cubietech/cubieboard1/rootfs_overlay"
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/cubietech/cubieboard1/genimage.cfg"
> +
> +# Buildroot
> +BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
> +BR2_GLOBAL_PATCH_DIR="board/cubietech/cubieboard1/patches"

These 2 options ^^^ should be place after 
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_8 to respect Buildroot option 
list sorting.

Also, for next times, once you have received a Reviewed-by: you should
keep it while respinning the patch, so if you send V4 you should add
what you find below.

I've build tested successfully using utils/docker-run and everything
else looks good to me, so, with the 2 options moved:
Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Best regards
-- 
Giulio Benetti
CEO&CTO@Benetti Engineering
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-05-30 20:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30 19:46 [Buildroot] [PATCH v3] configs/cubieboard1: new defconfig Gero Schwäricke
2024-05-30 20:55 ` Giulio Benetti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=427d70f0-cfe7-4fed-9d4f-be63ecc39ff8@benettiengineering.com \
    --to=giulio.benetti@benettiengineering.com \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox