From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller Date: Tue, 06 Dec 2016 14:02:45 +0100 Subject: [Buildroot] [PATCH] Makefile: generate KBUILD_BUILD_TIMESTAMP date whith LANG=C In-Reply-To: <1481019001-11035-1-git-send-email-jean-baptiste.tredez@basystemes.fr> References: <1481019001-11035-1-git-send-email-jean-baptiste.tredez@basystemes.fr> Message-ID: <4282667.A5TpXGPufD@sagittea> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Jean-Baptiste, On Tuesday 06 December 2016 11:10:01 Jean-Baptiste Tr?dez wrote: > Fix kernel reproducible build if LANG=fr_FR.UTF-8 in host system. > > when building linux kernel, scripts/gen_initramfs_list.sh do 'date -d"$KBUILD_BUILD_TIMESTAMP" +%s' > In buildroot makefile, KBUILD_BUILD_TIMESTAMP="$(shell date -d @$(SOURCE_DATE_EPOCH))" > if LANG=fr_FR.UTF-8 in host system, it does not work : > - LANG=C date -d"$(LANG=C date)" : ok > - LANG=C date -d"$(LANG=fr_FR.UTF-8 date)" : error Good catch. > --- > linux/linux.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux/linux.mk b/linux/linux.mk > index a63d1f3..554c5f1 100644 > --- a/linux/linux.mk > +++ b/linux/linux.mk > @@ -99,7 +99,7 @@ LINUX_MAKE_ENV += \ > KBUILD_BUILD_VERSION=1 \ > KBUILD_BUILD_USER=buildroot \ > KBUILD_BUILD_HOST=buildroot \ > - KBUILD_BUILD_TIMESTAMP="$(shell date -d @$(SOURCE_DATE_EPOCH))" > + KBUILD_BUILD_TIMESTAMP="$(shell LANG=C date -d @$(SOURCE_DATE_EPOCH))" It should also possible to fix problem using backquotes: KBUILD_BUILD_TIMESTAMP="`date -d @$(SOURCE_DATE_EPOCH)`" I find it lighter. BR, -- J?r?me Pouiller, Sysmic Embedded Linux specialist http://www.sysmic.fr