Re: [Buildroot] [PATCH v2 9/9] boot/uboot: add host-python-pkg-resources dependency

[Fiona Klute via buildroot <buildroot@buildroot.org>]

Am 15.10.26 um 21:32 schrieb James Hilliard:
> U-Boot configurations selecting BR2_TARGET_UBOOT_NEEDS_PYTHON3 already
> depend on host-python-setuptools, which provided pkg_resources before
> its removal in setuptools 82.
> 
> Add the standalone host package under the same condition to preserve
> pkg_resources availability for older U-Boot releases and vendor trees,
> including versions whose Binman still imports it.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> 
> ---
> Changes v1 -> v2:
>    - Tie host-python-pkg-resources to BR2_TARGET_UBOOT_NEEDS_PYTHON3
>      instead of BR2_TARGET_UBOOT_USE_BINMAN.

One thing I forgot to ask before: Why did you change this? AFAIK binman 
is the only U-Boot component that might need pkg_resources, and the 
dependency should be as narrow as possible.

Best regards,
Fiona

> ---
>   boot/uboot/uboot.mk | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index 96b8cd0d2e..daa841309c 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -268,7 +268,10 @@ UBOOT_MAKE_OPTS += DTC=$(HOST_DIR)/bin/dtc
>   endif
>   
>   ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON3),y)
> -UBOOT_DEPENDENCIES += host-python3 host-python-setuptools
> +UBOOT_DEPENDENCIES += \
> +	host-python3 \
> +	host-python-pkg-resources \
> +	host-python-setuptools
>   endif
>   
>   ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot