From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlos Santos Date: Fri, 21 Dec 2018 14:04:15 -0200 (BRST) Subject: [Buildroot] [PATCH v2 2/2] [RFC] package/pkg-waf.mk: mimic selection of host-waf In-Reply-To: <20181221163430.56a34588@windsurf> References: <20181221002221.16024-1-casantos@datacom.com.br> <20181221002221.16024-2-casantos@datacom.com.br> <20181221163430.56a34588@windsurf> Message-ID: <443080149.125007180.1545408255922.JavaMail.zimbra@datacom.com.br> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net > From: "Thomas Petazzoni" > To: "Carlos Santos" > Cc: "buildroot" , "Yann Morin" > Sent: Sexta-feira, 21 de dezembro de 2018 13:34:30 > Subject: Re: [Buildroot] [PATCH v2 2/2] [RFC] package/pkg-waf.mk: mimic selection of host-waf > Hello, > > On Thu, 20 Dec 2018 22:22:21 -0200, Carlos Santos wrote: >> Since host-waf's Config.in.host is blind, it is not possible to select >> it in the configuration menu. There are two possible solutions for this >> problem: >> >> - Add "select BR2_PACKAGE_HOST_WAF" to package/mpv/Config.in (currently >> only mpv requires host-waf). Also, document that BR2_PACKAGE_HOST_WAF >> must be selected when _NEEDS_EXTERNAL_WAF is YES. >> >> - Set BR2_PACKAGE_HOST_WAF to 'y' in the waf-package macro. This one is >> simpler because it does not require changing anything else. >> >> Signed-off-by: Carlos Santos > > I understand the idea that doing this avoids repeating a "select > BR2_PACKAGE_HOST_WAF" in all packages using host-waf. However, I don't > think we want to go down the route of setting those variables from the > make logic. I don't have a very strong argument to defend this > position, but to me it looks more logical that we continue to use > kconfig-level "select" to enable those config options. Thanks for reviewing this. So we need to make mpv select BR2_PACKAGE_HOST_WAF, right? -- Carlos Santos (Casantos) - DATACOM, P&D