Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Lindholm <holindho@cs.helsinki.fi>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC/PATCH 1/3] fix buildroot sed handling on Mac OS X
Date: Thu, 08 Mar 2007 23:36:22 +0200	[thread overview]
Message-ID: <45F081D6.3050803@cs.helsinki.fi> (raw)
In-Reply-To: <20070308163500.GC1389@aon.at>

Bernhard Fischer kirjoitti:
> On Sun, Feb 25, 2007 at 01:22:38PM +0200, Heikki Lindholm wrote:
> 
>>Improve the checking of sed by adding some common GNU sed installation
>>names (gsed/gnused), checking for a basic OS X sed feature in command
>>line option handling, checking the actual result of the sed run against
>>the expected result, and placing common code for the check under
>>toolchain/dependencies/.
>>
>>-- Heikki Lindholm
>>
> 
> 
>>diff -Nru buildroot/package/sed/sedcheck.sh buildroot-devel/package/sed/sedcheck.sh
>>--- buildroot/package/sed/sedcheck.sh	2007-02-22 10:50:29.000000000 +0200
>>+++ buildroot-devel/package/sed/sedcheck.sh	2007-02-23 17:39:04.000000000 +0200
>>@@ -2,24 +2,10 @@
>>
>># Make sure the host sed supports '-i' (in-place).
>># If it doesn't, we'll build and use our own.
>>+SED=$(toolchain/dependencies/check-host-sed.sh)
>>
>>-if test -x /usr/bin/sed ; then
>>-	SED="/usr/bin/sed"
>>-else
>>-	if test -x /bin/sed ; then
>>-		SED="/bin/sed"
>>-	else
>>-		SED="sed"
>>-	fi
>>-fi
>>-
>>-echo "HELLO" > .sedtest
>>-$SED -i -e "s/HELLO/GOODBYE/" .sedtest >/dev/null 2>&1
> 
> 
> Why don't you mv check-host-sed.sh here instead and use it in
> dependencies.sh? I'd prefer it this way..

Well. I tossed a coin on the placement. I thought checking the host sed 
would belong better to something build-framework-ish than the sed 
package. I'll do a respin of this if you like.

-- Heikki Lindholm

  reply	other threads:[~2007-03-08 21:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-25 11:22 [Buildroot] [RFC/PATCH 1/3] fix buildroot sed handling on Mac OS X Heikki Lindholm
2007-03-08 16:35 ` Bernhard Fischer
2007-03-08 21:36   ` Heikki Lindholm [this message]
2007-03-09  8:35     ` Bernhard Fischer
2007-03-09 19:28       ` Heikki Lindholm
  -- strict thread matches above, loose matches on Subject: below --
2007-02-23 16:10 Heikki Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45F081D6.3050803@cs.helsinki.fi \
    --to=holindho@cs.helsinki.fi \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox