From: Erik Stromdahl <erik.stromdahl@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] configs: raspberrypi3_64_defconfig: enable uart
Date: Sat, 15 Jul 2017 12:31:40 +0200 [thread overview]
Message-ID: <45fb0ba7-3682-7e5a-2843-e700fa338368@gmail.com> (raw)
In-Reply-To: <5969a4dfeb1b5_7fcd130b1a4601dd@ultri3.mail>
On 2017-07-15 07:15, Ricardo Martincoski wrote:
> Hello,
>
> On Fri, Jul 14, 2017 at 03:48 AM, Erik Stromdahl wrote:
>
>> This patch is necessary to preserve the same behaviour as
>> before the --uart-enable option in post-image.sh was
>
> s/--uart-enable/--enable-uart/
Right, bad commit comment indeed.
I'll change the comment.
>
>> introduced.
>
> Also, to me it looks like patch 3 and 4 should be merged.
> Let's see what others think.
>
I was actually thinking about this, but then I couldn't figure out a nice
header for the combined commit.
> [snip]
>> -BR2_ROOTFS_POST_SCRIPT_ARGS="--aarch64"
>> +BR2_ROOTFS_POST_SCRIPT_ARGS="--aarch64 --enable-uart)"
> ^
> I guess you meant
> BR2_ROOTFS_POST_SCRIPT_ARGS="--aarch64 --enable-uart"
Oops, the parenthesis in the end was not intended!
>
> Regards,
> Ricardo
>
prev parent reply other threads:[~2017-07-15 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 6:48 [Buildroot] [PATCH 1/4] board/raspberrypi/post-image.sh: add multi arg support Erik Stromdahl
2017-07-14 6:48 ` [Buildroot] [PATCH 2/4] board/raspberrypi/post-image.sh: add VC4 DTB overlay support Erik Stromdahl
2017-07-14 6:48 ` [Buildroot] [PATCH 3/4] board/raspberrypi/post-image.sh: add option for uart enable Erik Stromdahl
2017-07-14 6:48 ` [Buildroot] [PATCH 4/4] configs: raspberrypi3_64_defconfig: enable uart Erik Stromdahl
2017-07-15 5:15 ` Ricardo Martincoski
2017-07-15 10:31 ` Erik Stromdahl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45fb0ba7-3682-7e5a-2843-e700fa338368@gmail.com \
--to=erik.stromdahl@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox