Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rod Boyce <buildroot@teamboyce.co.uk>
To: buildroot@busybox.net
Subject: [Buildroot] ALSA tools for build-root
Date: Sat, 02 Jun 2007 12:06:50 +0100	[thread overview]
Message-ID: <46614F4A.8090703@teamboyce.co.uk> (raw)
In-Reply-To: <20070602103246.GL12010@aon.at>

Bernhard Fischer wrote:
>> +ALSA-TOOLS_DIR := $(BUILD_DIR)/$(patsubst %.tar.bz2,%,$(ALSA-TOOLS_SOURCE))
>>     
>
> Also, i'm curious where you picked up this notion of setting the
> FOO_DIR.
>
> The established way is a simple
> FOO_DIR:=$(BUILD_DIR)/foo-$(FOO_VERSION)
>   
This way means I only have to type the name and version once, I'm a 
great believer in if I can make something automatic then eliminate the 
chance the user (mostly me) can get it wrong the second time.  You 
rejected the $(shell basename .... ) approach which I agree with the 
rejection of using another shell to do something that make is quite 
capable of doing just makes sense.  I guess when I started looking at 
all this I used mpg123 version 16930 as my starting point.  I would 
prefer not to see this changed as long at the packaging convention is 
kept the same.  If the ALSA group ever change there packaging convention 
to not use name+version for the folder then I will change the *_DIR to 
suit.  But while it is the same and can be automatically extracted from 
the package filename I would prefer to use this automated approach.

Hope that makes sense, ultimately since I will not be personally 
committing this to SVN it is up to whoever commits this patch to SVN to 
decide.

Regards,
Rod Boyce

  reply	other threads:[~2007-06-02 11:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-02 10:00 [Buildroot] ALSA tools for build-root Rod Boyce
2007-06-02 10:26 ` Bernhard Fischer
2007-06-02 10:40   ` Rod Boyce
2007-06-02 10:32 ` Bernhard Fischer
2007-06-02 11:06   ` Rod Boyce [this message]
2007-06-06  6:38 ` Hans-Christian Egtvedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46614F4A.8090703@teamboyce.co.uk \
    --to=buildroot@teamboyce.co.uk \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox