From: Rod Boyce <buildroot@teamboyce.co.uk>
To: buildroot@busybox.net
Subject: [Buildroot] Update to mpg123
Date: Mon, 04 Jun 2007 21:34:31 +0100 [thread overview]
Message-ID: <46647757.6030306@teamboyce.co.uk> (raw)
In-Reply-To: <878xb0gkel.fsf@sleipner.barco.com>
Peter Korsgaard wrote:
> Thanks - A few commments:
>
> RB> -MPG123_VERSION=0.59r
> RB> +MPG123_VERSION := 0.65
>
> In the mean time 0.66 got released.
>
> RB> -MPG123_SOURCE=mpg123-$(MPG123_VERSION).tar.gz
> RB> -MPG123_CAT:=$(ZCAT)
> RB> -MPG123_SITE=http://www.mpg123.de/mpg123
> RB> -MPG123_DIR=$(BUILD_DIR)/mpg123-$(MPG123_VERSION)
> RB> +MPG123_SOURCE := mpg123-$(MPG123_VERSION).tar.bz2
> RB> +MPG123_CAT := $(BZCAT)
> RB> +MPG123_SITE := http://www.mpg123.de/download
> RB> +MPG123_DIR := $(BUILD_DIR)/mpg123-$(MPG123_VERSION)
>
> What's with all those white space changes? Could you please send an
> updated patch without those and with the version bumped to 0.66?
>
Peter & All,
Attached is another mpg123 patch with the version number bumped to
TODAY's new released version number. I have made no other changes to
this patch is considering the changes I had to make for the previous
version so minor which space changes are more than allowable in my
opinion. You are welcome to submit your own change that makes the code
harder to read, but I'll stay with a few more spaces and a slightly
prettier looking makefile fragment.
Regards,
Rod Boyce
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpg123-0.66_alsa.patch
Type: text/x-patch
Size: 2696 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20070604/90b29083/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpg123-0.66_noalsa.patch
Type: text/x-patch
Size: 2524 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20070604/90b29083/attachment-0001.bin
next prev parent reply other threads:[~2007-06-04 20:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-02 13:02 [Buildroot] Update to mpg123 Rod Boyce
2007-06-04 9:04 ` Peter Korsgaard
2007-06-04 20:34 ` Rod Boyce [this message]
2007-06-04 21:04 ` Bernhard Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46647757.6030306@teamboyce.co.uk \
--to=buildroot@teamboyce.co.uk \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox