From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Kuten Date: Sun, 14 Oct 2007 15:35:37 +0300 Subject: [Buildroot] PATCH: set BR2_INET_RPC dependency for nfs-utils and portmap In-Reply-To: <200710141130.49413.yann.morin.1998@anciens.enib.fr> References: <471159C8.4050603@promwad.com> <200710141130.49413.yann.morin.1998@anciens.enib.fr> Message-ID: <47120D19.8070807@promwad.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Yann E. MORIN wrote: > On Sunday 14 October 2007 01:50:32 Ivan Kuten wrote: >> Set BR2_INET_RPC dependency for nfs-utils and portmap: > > We had the same issue in BusyBox, and solved it the other way around: have > tools needing RPC do a 'select' on RPC, such as (this is not a patch!): > > ---8<--- > Index: package/nfs-utils/Config.in > =================================================================== > --- package/nfs-utils/Config.in (revision 20237) > +++ package/nfs-utils/Config.in (working copy) > @@ -1,6 +1,7 @@ > config BR2_PACKAGE_NFS_UTILS > bool "nfs-utils" > default n > + select BR2_INET_RPC > help > The NFS Linux kernel server. > Warning: We do not force largefile support on here on purpose. > Index: package/portmap/Config.in > =================================================================== > --- package/portmap/Config.in (revision 20237) > +++ package/portmap/Config.in (working copy) > @@ -1,6 +1,7 @@ > config BR2_PACKAGE_PORTMAP > bool "portmap" > default n > + select BR2_INET_RPC > help > The standard portmapper for RPC services. > > ---8<--- > > This is, imho, better this way because what people really want is NFS or > portmap, and might not know that RPC is needed to make those two available. > > Having NFS and portmap visible and 'select' the needed RPC support is more > straightforward. But again, this is my humble opinion. > Hello Yann, I completely agree with you, your approach is better. BR, Ivan