Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Dombroski <matthew.dombroski@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/libusb
Date: Fri, 13 Jun 2008 22:11:35 +1200	[thread overview]
Message-ID: <485247D7.5050708@gmail.com> (raw)
In-Reply-To: <20080613095801.GA31077@cloud.net.au>


>> -$(LIBUSB_DIR)/.configured: $(LIBUSB_DIR)/.unpacked
>> -	(cd $(LIBUSB_DIR); rm -rf config.cache; \
>> -		$(TARGET_CONFIGURE_OPTS) \
>> -		$(TARGET_CONFIGURE_ARGS) \
>> -		ac_cv_header_regex_h=no \
>>     
>
> It looked to me like something important was lost in your patch (it
> doesn't mention ac_cv_header_regex_h anywhere after patching), but
> looking at libusb's configure script it doesn't seem to be used anyway.
>   

I looked around at a few packages (xorg, glib, gtk) and saw they used a 
really tidy makefile.
Theres a bunch of targets in packages/Makefile.autotools.in that you can 
use to automate the process of building packages.
I just rewrote the entire libusb.mk to take advantage of those targets.

>> +$(LIBUSB_TARGET_INSTALL_TARGET): $(LIBUSB_TARGET_INSTALL_STAGING)
>> +	$(call MESSAGE,"Installing to target")
>>     
>> -libusb: uclibc $(TARGET_DIR)/$(LIBUSB_BINARY)
>> +$(LIBUSB_TARGET_UNINSTALL):
>> +	$(call MESSAGE,"Uninstalling")
>>     
>
> Why the messages? Is this standard among our autotools-using packages?

Im just copying the format of the package install process in 
Makefile.autotools.in.
That and I think it looks better :)

The purpose of overriding the un/install to target is to stop the 
copying of static libs and docs to the target filesystem. Theyre still 
copied to the $(STAGING_DIR) though.

$(LIBUSB_TARGET_INSTALL_TARGET): $(LIBUSB_TARGET_INSTALL_STAGING)
    $(call MESSAGE,"Installing to target")
    cp -dpf $(STAGING_DIR)/usr/lib/libusb*.so* $(TARGET_DIR)/usr/lib/
    $(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/lib/libusb*.so*
    $(Q)touch $@

~Matt

  reply	other threads:[~2008-06-13 10:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-13  5:53 [Buildroot] svn commit: trunk/buildroot/package/libusb hamish at uclibc.org
2008-06-13  6:25 ` Hamish Moffatt
2008-06-13  8:07   ` Matthew Dombroski
2008-06-13  9:58     ` Hamish Moffatt
2008-06-13 10:11       ` Matthew Dombroski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-12-05 10:22 jacmet at uclibc.org
2008-12-05 10:42 ` Gaye Abdoulaye Walsimou
2008-12-08 21:08   ` Peter Korsgaard
2008-12-09  0:46     ` Hamish Moffatt
2008-06-13  8:47 jacmet at uclibc.org
2008-06-13  8:45 jacmet at uclibc.org
2008-06-13 10:02 ` Hamish Moffatt
2008-06-13 10:18   ` Peter Korsgaard
2008-05-28  6:54 hamish at uclibc.org
2008-05-28  2:12 hamish at uclibc.org
2008-03-27 13:00 jacmet at uclibc.org
2008-02-18 14:30 sjhill at uclibc.org
2008-02-15 14:06 jacmet at uclibc.org
2007-11-09  9:30 vanokuten at uclibc.org
2007-11-09  9:26 vanokuten at uclibc.org
2007-09-25 12:54 ulf at uclibc.org
2007-09-20  9:35 aldot at uclibc.org
2007-08-31 12:04 aldot at uclibc.org
2007-08-21 18:30 aldot at uclibc.org
2007-07-16  9:45 ulf at uclibc.org
2007-05-07  4:00 sjhill at uclibc.org
2007-05-07  9:41 ` Assen Stoyanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=485247D7.5050708@gmail.com \
    --to=matthew.dombroski@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox