From: Nick Peirson <nick@netcentral.co.uk>
To: buildroot@busybox.net
Subject: [Buildroot] Patch review
Date: Fri, 31 Oct 2008 10:57:15 +0000 [thread overview]
Message-ID: <490AE48B.20306@netcentral.co.uk> (raw)
In-Reply-To: <20081031104315.GJ26468@mx.loc>
Bernhard Reutner-Fischer wrote:
> I did not need any patches to syslinux itself but had to add nasm
> support for both the host and the target?
I added nasm on the host, but didn't make any changes to the target. The
error I was getting was due to syslinux makefile specifying "-Wall
-Werror" and printf throwing a warning when called without a format string.
> Did you send the non-makefile patch upstream? If you didn't already then
> please do now..
I wasn't sure if the bug was related to buildroot/uclibc, which I
mentioned in the bug notes, but I'll send it upstream and see what's
made of it.
Thanks
Nick
next prev parent reply other threads:[~2008-10-31 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 9:50 [Buildroot] Patch review Nick Peirson
2008-10-31 10:43 ` Bernhard Reutner-Fischer
2008-10-31 10:57 ` Nick Peirson [this message]
2008-10-31 15:26 ` Nick Peirson
2008-11-02 18:33 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490AE48B.20306@netcentral.co.uk \
--to=nick@netcentral.co.uk \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox