Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Will Wagner <will_wagner@carallon.com>
To: buildroot@busybox.net
Subject: [Buildroot] uClibc copying kernel headers
Date: Wed, 27 Jan 2010 18:55:22 +0000	[thread overview]
Message-ID: <4B608C1A.70901@carallon.com> (raw)

I have been trying to work out who copied the kernel headers from 
toolchain into staging. It appears this is done in uclibc.mk

Looking at the makefile this seems to happen three times, first copying 
into $(TOOLCHAIN_DIR)/uClibc_dev/usr/include, then into 
$(STAGING_DIR)/usr/include and finally into $(TARGET_DIR)/usr/include 
(only if libc.a is on target)

All of these cases have different behaviour depending on whether ifeq 
($(LINUX_HEADERS_IS_KERNEL),y) is true. if it is it just copies all th 
files, otherwise it picks out a specific subset. However search all the 
buildroot files LINUX_HEADERS_IS_KERNEL is never mentioned except in 
uclibc.mk

Looking back through earlier buildroot versions, Peter removed the last 
mention to LINUX_HEADERS_IS_KERNEL with this commit to remove 2.4.x 
kernel header support 
http://lists.busybox.net/pipermail/buildroot/2009-February/026144.html

It appears that before this LINUX_HEADERS_IS_KERNEL was set true for 
2.6.x and false for 2.4.x. It looks to me like that change broke the 
copying of kernel headers for 2.6.x and left code in uclibc.mk that was 
meant for 2.4.x headers.

I think I can just change uclibc.mk so that it acts as if 
LINUX_HEADERS_IS_KERNEL is set.

Does this look right?

As an aside there looks to be an error in uclibc.mk at the moment on 
line 429, although that is code that i think should be removed.

I will attempt to make the changes and if it all works I will submit a patch

Will

             reply	other threads:[~2010-01-27 18:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27 18:55 Will Wagner [this message]
2010-01-27 19:23 ` [Buildroot] uClibc copying kernel headers Bernhard Reutner-Fischer
2010-01-28 18:09 ` William Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B608C1A.70901@carallon.com \
    --to=will_wagner@carallon.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox