Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Will Wagner <will_wagner@carallon.com>
To: buildroot@busybox.net
Subject: [Buildroot] make -C <buildroot_directory> failed
Date: Tue, 23 Feb 2010 22:47:52 +0000	[thread overview]
Message-ID: <4B845B18.9080102@carallon.com> (raw)
In-Reply-To: <4f6b.4b844ff0.25c53@getafix.xdna.net>

On 23/02/2010 22:00, Cameron Hutchison wrote:
> "Matthew Davison"<matt.davison@lantronix.com>  writes:
>
>    
>> Attempting to invoke the top level buildroot makefile from a higher
>> level Makefile or simply with make -C<buildroot_directory>  fails during
>> the kernel build. This is even true if 'make -C .' is invoked from the
>> top level buildroot directory, as long as a kernel build is enabled. It
>> appears that the problem has something to do with make's
>> "Entering/Leaving directory" messages, as the output below suggests.
>> When I passed the --no-print-directory option to make, I was able to
>> build without problems.
>>      
> I think I see the problem. See if this patch fixes it. I haven't tested
> this, but this looks right.
>    

I agree correct fix.

That's the same as the patch I submitted here: 
http://lists.busybox.net/pipermail/buildroot/2010-January/031690.html
> > From 5dbf2e25bbd7d4f4586888384b3c207dd1a6afca Mon Sep 17 00:00:00 2001
> From: Cameron Hutchison<cam@camh.ch>
> Date: Wed, 24 Feb 2010 08:52:44 +1100
> Subject: [PATCH] Fix probing of kernel version
>
> Probing the kernel version uses command substitution to capture the
> result of a make command. If the top-level make is run with -C, the
> sub-make will print entering/leaving directory messages, mucking up the
> output we're trying to capture.
>
> Invoke the sub-make with --no-print-directory so we get clean output.
>
> Signed-off-by: Cameron Hutchison<cam@camh.ch>
> ---
>   target/linux/Makefile.in.advanced |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target/linux/Makefile.in.advanced b/target/linux/Makefile.in.advanced
> index b4774ca..7679d1e 100644
> --- a/target/linux/Makefile.in.advanced
> +++ b/target/linux/Makefile.in.advanced
> @@ -41,7 +41,7 @@ endif
>   endif
>
>   # Ask the kernel what version number it will use when installing modules
> -LINUX26_VERSION_PROBED = `$(MAKE) $(LINUX26_MAKE_FLAGS) -C $(LINUX26_DIR) -s kernelrelease`
> +LINUX26_VERSION_PROBED = `$(MAKE) $(LINUX26_MAKE_FLAGS) -C $(LINUX26_DIR) --no-print-directory -s kernelrelease`
>
>   ifeq ($(BOARD_PATH),)
>   BOARD_PATH:=$(call qstrip,$(BR2_BOARD_PATH))
>    

  parent reply	other threads:[~2010-02-23 22:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-23 20:56 [Buildroot] make -C <buildroot_directory> failed Matthew Davison
2010-02-23 21:40 ` Peter Korsgaard
2010-02-23 22:00 ` Cameron Hutchison
2010-02-23 22:19   ` Peter Korsgaard
2010-02-23 22:25   ` Yann E. MORIN
2010-02-23 22:47   ` Will Wagner [this message]
2010-02-23 22:56     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B845B18.9080102@carallon.com \
    --to=will_wagner@carallon.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox