Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Will Wagner <will_wagner@carallon.com>
To: buildroot@busybox.net
Subject: [Buildroot] Converting packages to autotools leading to more in target filesystem
Date: Wed, 19 May 2010 14:55:36 +0100	[thread overview]
Message-ID: <4BF3EDD8.2070809@carallon.com> (raw)

I have been updating a project to use the latest buildroot from git and 
I have noticed a change in the size of the target filesystem.

This is caused by the conversion of certain packages to use the 
autotools infrastructure. The two packages in the tree I have noticed it 
for are libsysfs and libraw1394. These are both libraries and previously 
the install step for the target just copied the libraries into 
$(TARGET_DIR)/usr/lib.

With the conversion to autotools instead the target install step is 
calling install-strip on the Makefile in the package source. This 
correctly installs the library but it also copies a number of test 
applications that come bundled with the library. For my project where 
filesystem size is constrained this can cause problems. If a system was 
not constrained for filesystem size I can see that the test applications 
could be useful to allow someone to test the library was working correctly.

I was easily able to remove the unwanted applications by adding a 
INSTALL_TARGET_CMDS override for the package as below:

--- a/package/libraw1394/libraw1394.mk
+++ b/package/libraw1394/libraw1394.mk
@@ -8,4 +8,8 @@ LIBRAW1394_SOURCE:=libraw1394-$(LIBRAW1394_VERSION).tar.gz
  LIBRAW1394_SITE:=http://www.kernel.org/pub/linux/libs/ieee1394/
  LIBRAW1394_INSTALL_STAGING=YES

+define LIBRAW1394_INSTALL_TARGET_CMDS
+       $(MAKE) DESTDIR=$(TARGET_DIR)  install-strip -C 
$(BUILD_DIR)/libraw1394-$(LIBRAW1394_VERSION)/src
+endef
+
  $(eval $(call AUTOTARGETS,package,libraw1394))

This works fine but forces all users to have a cut down install. Is this 
a problem people think is worth solving? If so I will look at changing 
it so that the autotools infrastructure can choose (depending on a 
global config option) to either install the entire package or you can 
specify make targets that only install some of the package.

Will

             reply	other threads:[~2010-05-19 13:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19 13:55 Will Wagner [this message]
2010-05-19 20:35 ` [Buildroot] Converting packages to autotools leading to more in target filesystem Lionel Landwerlin
2010-05-20  9:24   ` William Wagner
2010-05-20  9:48     ` Lionel Landwerlin
2010-05-20 12:06       ` Paulius Zaleckas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF3EDD8.2070809@carallon.com \
    --to=will_wagner@carallon.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox