Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: William Wagner <will_wagner@carallon.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] Fix externals-deps and source-check when building out of tree
Date: Mon, 30 Aug 2010 14:40:39 +0100	[thread overview]
Message-ID: <4C7BB4D7.4020909@carallon.com> (raw)
In-Reply-To: <8762ytyuqc.fsf@macbook.be.48ers.dk>

  On 29/08/2010 22:28, Peter Korsgaard wrote:
>
>   Will>  Signed-off-by: Will Wagner<will_wagner@carallon.com>
>   Will>  ---
>   Will>   Makefile |    6 +++---
>   Will>   1 files changed, 3 insertions(+), 3 deletions(-)
>
>   Will>  diff --git a/Makefile b/Makefile
>   Will>  index 291badf..7345beb 100644
>   Will>  --- a/Makefile
>   Will>  +++ b/Makefile
>   Will>  @@ -432,10 +432,10 @@ endif
>   Will>   source: $(TARGETS_SOURCE) $(HOST_SOURCE)
>
>   Will>   _source-check:
>   Will>  -	$(MAKE) SPIDER=--spider source
>   Will>  +	$(MAKE) O=$(O) SPIDER=--spider source
>
> No that then breaks the build for ! O=<dir>  builds. I've committed a
> slightly different fix that works for both situations.

Ok, I'll take a look at your fix to see what I did wrong!

> I see your patch is named 4/4, but I don't see any other patches from
> you around that day - Was that just a mistake or did they get lost
> somehow?
>
Was putting together some other patches for new packages, thought I'd 
send them after this release. Still not quite got the hang of git 
send-email.

Thanks
Will

-- 
------------------------------------------------------------------------
Will Wagner                                     will_wagner at carallon.com
Development Manager                      Office Tel: +44 (0)20 7371 2032
Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA
------------------------------------------------------------------------

  reply	other threads:[~2010-08-30 13:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-25 10:28 [Buildroot] [PATCH 4/4] Fix externals-deps and source-check when building out of tree Will Wagner
2010-08-29 21:28 ` Peter Korsgaard
2010-08-30 13:40   ` William Wagner [this message]
2010-08-30 14:20     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C7BB4D7.4020909@carallon.com \
    --to=will_wagner@carallon.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox