Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: William Wagner <will_wagner@carallon.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Repair initramfs dependancies after move to fs
Date: Thu, 04 Nov 2010 16:51:39 +0000	[thread overview]
Message-ID: <4CD2E49B.2070402@carallon.com> (raw)
In-Reply-To: <20101104171659.3aaa4f94@surf>

On 04/11/2010 16:16, Thomas Petazzoni wrote:
> Hello Will,
>
> I'm replying on this old patch that I acked back in April. But I now
> have one question. While I still agree on the changes on
> target/linux/Makefile* (now linux/linux.mk), I don't understand why the
> following change was needed:
>
>> diff --git a/fs/initramfs/initramfs.mk b/fs/initramfs/initramfs.mk
>> index 4a205d1..9aaf1b0 100644
>> --- a/fs/initramfs/initramfs.mk
>> +++ b/fs/initramfs/initramfs.mk
>> @@ -6,6 +6,12 @@
>>   #
>>   #############################################################
>>
>> +ifeq ($(BR2_TARGET_ROOTFS_INITRAMFS),y)
>> +INITRAMFS_TARGET:=initramfs-root
>> +else
>> +INITRAMFS_TARGET:= #nothing
>> +endif
> the INITRAMFS_TARGET variable isn't used anywhere in the current git.
> Isn't this code useless ? (I think it is, but I'd like to be sure).

Yes I think you are right. It looks like this was only needed with the 
old kernel build sequence, the new linux/linux.mk doesn't need it.

Will

-- 
------------------------------------------------------------------------
Will Wagner                                     will_wagner at carallon.com
Development Manager                      Office Tel: +44 (0)20 7371 2032
Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA
------------------------------------------------------------------------

      reply	other threads:[~2010-11-04 16:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-19 14:34 [Buildroot] [PATCH] Repair initramfs dependancies after move to fs Will Wagner
2010-04-19 21:07 ` Thomas Petazzoni
2010-04-19 22:03 ` Peter Korsgaard
2010-11-04 16:16 ` Thomas Petazzoni
2010-11-04 16:51   ` William Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CD2E49B.2070402@carallon.com \
    --to=will_wagner@carallon.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox