From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 03/28] linux: make it possible to install the kernel in /boot
Date: Thu, 07 Jul 2011 12:04:49 +0200 [thread overview]
Message-ID: <4E1584C1.3060203@lucaceresoli.net> (raw)
In-Reply-To: <201107042348.43715.yann.morin.1998@anciens.enib.fr>
Yann E. MORIN wrote:
> Thomas, All,
>
> On Monday 04 July 2011 23:33:20 Thomas Petazzoni wrote:
>> Signed-off-by: Thomas Petazzoni<thomas.petazzoni@free-electrons.com>
>> ---
>> linux/Config.in | 7 +++++++
>> linux/linux.mk | 3 +++
>> 2 files changed, 10 insertions(+), 0 deletions(-)
>>
>> diff --git a/linux/Config.in b/linux/Config.in
>> index 1f1a69c..c9229a5 100644
>> --- a/linux/Config.in
>> +++ b/linux/Config.in
>> @@ -153,6 +153,13 @@ config BR2_LINUX_KERNEL_IMAGE_TARGET_NAME
>> Specify the kernel make target to build the kernel that you
>> need.
>>
>> +config BR2_LINUX_KERNEL_INSTALL_TARGET
>> + bool "Install kernel image to /boot in target"
>> + help
>> + Select this option to have the kernel image installed to
>> + /boot in the target root filesystem, as is typically done on
>> + x86/x86_64 systems.
>> +
>> endif # BR2_LINUX_KERNEL
>>
>> endmenu
>> diff --git a/linux/linux.mk b/linux/linux.mk
>> index 43ca87b..2bb32cb 100644
>> --- a/linux/linux.mk
>> +++ b/linux/linux.mk
>> @@ -158,6 +158,9 @@ $(LINUX26_DIR)/.stamp_compiled: $(LINUX26_DIR)/.stamp_configured $(LINUX26_DIR)/
>> $(LINUX26_DIR)/.stamp_installed: $(LINUX26_DIR)/.stamp_compiled
>> @$(call MESSAGE,"Installing kernel")
>> cp $(LINUX26_IMAGE_PATH) $(BINARIES_DIR)
>> +ifeq ($(BR2_LINUX_KERNEL_INSTALL_TARGET),y)
>> + install -m 0644 -D $(LINUX26_IMAGE_PATH) $(TARGET_DIR)/boot/$(LINUX26_IMAGE_NAME)
>> +endif
>
> If we install the kernel in /boot, why do we stil install it in
> ${BINARIES_DIR} ?
>
> It can only be confusing to have the kernel image in two places.
Does this really hurt? I found that a handy _feature_ indeed.
Well, sorry for writing after v3 was submitted, but Thomas was so much
faster than my review! :)
I need the kernel in the target for some products, but with v2 of
Thomas' work I also was sure that I always have an uImage in
output/images, ready for network boot via TFTP and other stuff.
Now I'd have to try both places, or script around the config to know
where I'll find my uImage.
I'd rather come back to v2, but if you mind a few MB wasted on the
development host, an additional option (say, "Copy kernel image to
/images dir") would save both needs.
Luca
next prev parent reply other threads:[~2011-07-07 10:04 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 21:33 [Buildroot] [pull request v2] Pull request for branch for-2011.08/bootloaders Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 01/28] Makefile.package.in: Makes it possible to override the default extract commands Thomas Petazzoni
2011-07-04 21:45 ` Yann E. MORIN
2011-07-04 22:07 ` Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 02/28] Fix quoting in default extract command Thomas Petazzoni
2011-07-04 21:54 ` Yann E. MORIN
2011-07-04 21:33 ` [Buildroot] [PATCH 03/28] linux: make it possible to install the kernel in /boot Thomas Petazzoni
2011-07-04 21:48 ` Yann E. MORIN
2011-07-05 19:23 ` Thomas Petazzoni
2011-07-07 10:04 ` Luca Ceresoli [this message]
2011-07-07 21:14 ` Peter Korsgaard
2011-07-04 21:33 ` [Buildroot] [PATCH 04/28] linux: use the defconfig mechanism after tuning the config Thomas Petazzoni
2011-07-04 21:52 ` Yann E. MORIN
2011-07-04 21:33 ` [Buildroot] [PATCH 05/28] package: add infrastructure to install things in images/ Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 06/28] package: fix patching procedure for host packages Thomas Petazzoni
2011-07-04 22:01 ` Yann E. MORIN
2011-07-05 7:28 ` Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 07/28] barebox: use = instead of := and re-indent Thomas Petazzoni
2011-07-04 22:08 ` Yann E. MORIN
2011-07-05 7:31 ` Thomas Petazzoni
2011-07-05 21:04 ` Peter Korsgaard
2011-07-04 21:33 ` [Buildroot] [PATCH 08/28] barebox: convert to GENTARGETS Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 09/28] at91bootstrap: use = instead of := and indent properly Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 10/28] at91bootstrap: convert to GENTARGETS Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 11/28] at91dataflashboot: use = instead of := and indent Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 12/28] at91dataflashboot: convert to GENTARGETS Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 13/28] syslinux: " Thomas Petazzoni
2011-07-04 22:12 ` Yann E. MORIN
2011-07-05 19:46 ` Thomas Petazzoni
2011-07-05 21:28 ` Yann E. MORIN
2011-07-04 21:33 ` [Buildroot] [PATCH 14/28] grub: convert to AUTOTARGETS Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 15/28] grub2: remove package Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 16/28] u-boot: convert to GENTARGETS Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 17/28] uboot-mkimage: new package Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 18/28] linux: rename LINUX26 to LINUX Thomas Petazzoni
2011-07-05 14:24 ` Dechesne, Nicolas
2011-07-05 19:11 ` Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 19/28] linux: indent and align some definitions Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 20/28] package: add support for post-download hooks Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 21/28] linux: convert to the GENTARGETS infrastructure Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 22/28] boot: rename BR2_TARGET_* to BR2_BOOT_* Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 23/28] u-boot: rename options BR2_BOOT_UBOOT* to BR2_BOOT_U_BOOT* Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 24/28] Improve TARGETS handling for bootloaders and kernel Thomas Petazzoni
2011-07-04 22:27 ` Yann E. MORIN
2011-07-05 19:47 ` Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 25/28] linux: allow specification of a custom Git repository as a source Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 26/28] u-boot: allow specification of custom Git repo as source Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 27/28] Add x-loader bootloader Thomas Petazzoni
2011-07-04 21:33 ` [Buildroot] [PATCH 28/28] barebox: bump version Thomas Petazzoni
2011-07-04 21:44 ` [Buildroot] [pull request v2] Pull request for branch for-2011.08/bootloaders Yann E. MORIN
2011-07-04 22:01 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2011-07-05 19:53 [Buildroot] [pull request v3] " Thomas Petazzoni
2011-07-05 19:53 ` [Buildroot] [PATCH 03/28] linux: make it possible to install the kernel in /boot Thomas Petazzoni
2011-07-07 19:08 ` Sven Neumann
2011-07-07 21:17 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1584C1.3060203@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox