Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/3] netsnmp: allow not to install MIB files
Date: Wed, 31 Aug 2011 14:48:16 +0200	[thread overview]
Message-ID: <4E5E2D90.2000307@lucaceresoli.net> (raw)
In-Reply-To: <201108301950.37244.yann.morin.1998@anciens.enib.fr>

Yann E. MORIN wrote:
> Luca, All,
>
> On Thursday 16 June 2011 17:27:13 Luca Ceresoli wrote:
>> Signed-off-by: Luca Ceresoli<luca@lucaceresoli.net>
>> ---
>> Changes in v2:
>>   - MIB installation is forcibly enabled with the MIB loading code; otherwise
>>     net-snmp would loudly flood the console for missing MIBs.
>>
>>   package/netsnmp/Config.in  |    8 ++++++++
>>   package/netsnmp/netsnmp.mk |    4 ++++
>>   2 files changed, 12 insertions(+), 0 deletions(-)
>>
>> diff --git a/package/netsnmp/Config.in b/package/netsnmp/Config.in
>> index 6f88b03..a6a768c 100644
>> --- a/package/netsnmp/Config.in
>> +++ b/package/netsnmp/Config.in
>> @@ -10,6 +10,14 @@ config BR2_PACKAGE_NETSNMP_ENABLE_MIB_LOADING
>>   	bool "Enable MIB loading code"
>>   	default y
>>   	depends on BR2_PACKAGE_NETSNMP
>> +	select BR2_PACKAGE_NETSNMP_INSTALL_MIBS
>
> Well, I'd do the other way around: if MIB files are to be installed, then
> we need to be able to load them, so I'd do either:
>
>      config BR2_PACKAGE_NETSNMP_INSTALL_MIBS
>          depends on BR2_PACKAGE_NETSNMP_ENABLE_MIB_LOADING
>
> Or:
>
>      config BR2_PACKAGE_NETSNMP_INSTALL_MIBS
>          depends on BR2_PACKAGE_NETSNMP
>          select BR2_PACKAGE_NETSNMP_ENABLE_MIB_LOADING

The problem is net-snmp wants the MIBs installed when the MIB loading
code is enabled, so this combination would be very annoying.

The use case you think about is that the user wants to provide his own
MIB files. If he did, he would need to install also the base MIBs (the
same installed by net-snmp), because it is impossible to load any MIB
node without having the definition for the parent MIB nodes.

So I think this use case would be so limited that it's not worth
supporting it. At least not until anybody has this need.

So I think Gustavo's proposal is best: one option only to either enable
both features or disable both.

If you agree, I'll prepare a new patchset.

Luca

  reply	other threads:[~2011-08-31 12:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-15 15:47 [Buildroot] [PATCH 1/2] netsnmp: fix stop and restart actions in init script Luca Ceresoli
2011-06-15 15:47 ` [Buildroot] [PATCH 2/2] netsnmp: allow not to install MIB files Luca Ceresoli
2011-06-16 15:27 ` [Buildroot] [PATCH v2 0/3] netsnmp improvements Luca Ceresoli
2011-06-16 15:27   ` [Buildroot] [PATCH v2 1/3] netsnmp: fix stop and restart actions in init script Luca Ceresoli
2011-06-16 15:27   ` [Buildroot] [PATCH v2 2/3] netsnmp: allow to disable MIB loading code Luca Ceresoli
2011-06-16 15:27   ` [Buildroot] [PATCH v2 3/3] netsnmp: allow not to install MIB files Luca Ceresoli
2011-08-30 17:50     ` Yann E. MORIN
2011-08-31 12:48       ` Luca Ceresoli [this message]
2011-08-31 13:33         ` Yann E. MORIN
2011-08-30 17:39   ` [Buildroot] [PATCH v2 0/3] netsnmp improvements Gustavo Zacarias
2011-08-31 19:46   ` [Buildroot] [PATCH v3 1/2] netsnmp: fix stop and restart actions in init script Luca Ceresoli
2011-08-31 19:46     ` [Buildroot] [PATCH v3 2/2] netsnmp: allow to disable MIB files installation and MIB loading code Luca Ceresoli
2011-08-31 20:38       ` Yann E. MORIN
2011-09-11 21:10       ` Peter Korsgaard
2011-09-11 21:09     ` [Buildroot] [PATCH v3 1/2] netsnmp: fix stop and restart actions in init script Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5E2D90.2000307@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox