Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yegor Yefremov <yegor_sub1@visionsystems.de>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC] New package: QSerialDevice
Date: Tue, 25 Oct 2011 11:22:32 +0200	[thread overview]
Message-ID: <4EA67FD8.2040801@visionsystems.de> (raw)
In-Reply-To: <20111025101709.3851667f@skate>

Am 25.10.2011 10:17, schrieb Thomas Petazzoni:
> Le Tue, 25 Oct 2011 09:22:34 +0200,
> Yegor Yefremov <yegor_sub1@visionsystems.de> a ?crit :
>
>> 1. I fetch it from git branch, how can I specify revision?
> pkg_VERSION = ...
>
> You can specify a git branch, a git commit, whatever commit identifier
> that is valid for git.

But how can I combine branch name together with commit? I've already specified branch "2.0" as QSERIALDEVICE_VERSION.

>> 2. how do I handle symlinking for libraries? If I just copy all 4
>> files, I get 4 same files and not one library and 3 symlinks
> Either use the "make install" of the package (or implement it), or use
> ln to create the symlinks.

O.K. I thought there would be some kind of elegant and easy way, like an option that copies only symlink and not it's target if desired :-)

>> 3. what
>> about creating some kind of folders/menu (in package/Config.in) for
>> Qt, python etc. add-ons?
> I don't know. qserialdevice should go in Libraries -> Hardware
> handling. I don't see why it would need to end up in a qt-specific
> submenu.

O.K.

>> +define QSERIALDEVICE_CONFIGURE_CMDS
>> +	$(QT_QMAKE) $(@D)/serialport.pro
>> +endef
> Should be:
>
> 	(cd $(@D); $(QT_QMAKE) serialport.pro)

You won't believe me, but it worked without cd statement. That's why I was puzzled by my local package not willing to create Makefile in output/build/vsguitest. But I fix it for QSerialDevice for conformance sake.

>
> Does it *absolutely* require udev ? I have never used QSerialDevice,
> but QExtSerialPort instead, and udev wasn't necessary.

It requires both build-time and run-time udev. This package provides two classes/interfaces:

1. serial port itself
2. informational class containing all installed serial port sin the system and it uses libudev (I'll send a patch that installs udev in staging)

Yegor

  reply	other threads:[~2011-10-25  9:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-25  7:22 [Buildroot] [RFC] New package: QSerialDevice Yegor Yefremov
2011-10-25  8:17 ` Thomas Petazzoni
2011-10-25  9:22   ` Yegor Yefremov [this message]
2011-10-25  9:29     ` Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA67FD8.2040801@visionsystems.de \
    --to=yegor_sub1@visionsystems.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox